This repository has been archived by the owner on Jan 29, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1k
$missingTranslationHandlerFactory does not work well with angular-translate-loader-url #74
Labels
Comments
Hey @jamesandres could you please set up a plunk? Cause this should actually work properly. |
Sure thing |
@jamesandres Damn it. you're right. I'll label this issue as a bug and hope to get it fixed as soon as possible! |
0x-r4bbit
added a commit
that referenced
this issue
Jun 21, 2013
this fix makes sure that missingTranslationHandlerFactory only gets called when there is no pending loader to laod translations asynchronously. Closes #74
Hey @jamesandres I pushed a patch to |
Yep that's working for me. Thanks! |
Landed in master as Do |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Hi @PascalPrecht ,
I am working at integrating the angular-translate-loader-url project into my codebase but it isn't playing nice with $missingTranslationHandlerFactory. The behaviour I'm seeing looks like this.
undefined
How I wish it would behave:
translate
filter / directive does not run until the translations are fetched from $http servicetranslate
filter / directive is invoked and $missingTranslationHandlerFactory is called as neededYour thoughts?
The text was updated successfully, but these errors were encountered: