Skip to content
This repository has been archived by the owner on Jan 29, 2024. It is now read-only.

translationNotFoundIndicator doesn't work with translate filter on 2.5.2 #866

Closed
keirlawson opened this issue Dec 19, 2014 · 5 comments
Closed

translationNotFoundIndicator doesn't work with translate filter on 2.5.2 #866

keirlawson opened this issue Dec 19, 2014 · 5 comments
Labels
bug waiting
Milestone
2.6.0

Comments

@keirlawson
Copy link

My indicators are not appended to either side of the translation. I'm using angular 1.2.27, I can recreate this issue here:

http://plnkr.co/edit/pz8Q2oOCbm8PGyRSQSpa?p=preview
@tspaeth tspaeth added the bug label Dec 26, 2014
@tspaeth
Copy link
Member

tspaeth commented Dec 26, 2014

Yes, this looks like a problem of the filter implementation in the current version.
If you use the directive syntax, the indicators are applied.

@tspaeth tspaeth mentioned this issue Dec 26, 2014
Closed
@tspaeth
Copy link
Member

tspaeth commented Dec 26, 2014

@Snowball I've taken a look at that issue. Hopefully the linked #870 fixes your problem.

Anyway, I've tested it also against 2.0.0 ... somehow I have the feeling that it never worked... :-)

@keirlawson
Copy link
Author

Yup, found this issue when upgrading from 1.x, broke a bunch of our tests

@knalli knalli added this to the 2.6.0 milestone Dec 28, 2014
@knalli
Copy link
Member

knalli commented Jan 10, 2015

fyi: #870 was merged/picked.

@knalli
Copy link
Member

knalli commented Jan 12, 2015

Is this closed by 870?

@knalli knalli added the waiting label Feb 8, 2015
@tspaeth tspaeth closed this as completed in 5a9f436 Feb 8, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug waiting
Projects
None yet
Milestone
2.6.0
Development

No branches or pull requests
3 participants
@keirlawson @knalli @tspaeth