fix(filter): apply notFoundIndicators also for instant translations c…

…orrectly Fixes #866
angular-translate · Jan 10, 2015 · 5a9f436 · 5a9f436
1 parent b61723e
commit 5a9f436
Show file tree

Hide file tree

Showing 2 changed files with 28 additions and 0 deletions.
diff --git a/src/service/translate.js b/src/service/translate.js
@@ -1685,6 +1685,8 @@ angular.module('pascalprecht.translate').provider('$translate', ['$STORAGE_KEY',
           if ($translationTable[possibleLangKey]) {
             if (typeof $translationTable[possibleLangKey][translationId] !== 'undefined') {
               result = determineTranslationInstant(translationId, interpolateParams, interpolationId);
+            } else if ($notFoundIndicatorLeft || $notFoundIndicatorRight) {
+              result = applyNotFoundIndicators(translationId);
             }
           }
           if (typeof result !== 'undefined') {

diff --git a/test/unit/filter/translate.spec.js b/test/unit/filter/translate.spec.js
@@ -147,4 +147,30 @@ describe('pascalprecht.translate', function () {
       expect($translate('FOO', {}, 'custom')).toEqual('custom interpolation');
     }));
   });
+  describe('shall add the prefix and suffix elements', function () {
+
+    beforeEach(module('pascalprecht.translate', function ($translateProvider, $provide) {
+
+      $translateProvider.translations('en', {
+        'FOO': 'Have foo'
+      });
+
+      $translateProvider
+        .preferredLanguage('en')
+        .translationNotFoundIndicator('-+-+');
+    }));
+
+    var $translate, $filter, $rootScope, $q;
+    beforeEach(inject(function (_$filter_, _$rootScope_, _$q_) {
+      $filter = _$filter_;
+      $rootScope = _$rootScope_;
+      $q = _$q_;
+      $translate = $filter('translate');
+    }));
+
+    it('should contain the not found indicators', inject(function () {
+      expect($translate('FOO')).toEqual('Have foo');
+      expect($translate('FOO2')).toEqual('-+-+ FOO2 -+-+');
+    }));
+  });
 });