Skip to content
This repository has been archived by the owner on Nov 30, 2018. It is now read-only.

Custom icon only works on ui-gmap-markers and not a singular marker #1408

Open
intellix opened this issue Jul 26, 2015 · 20 comments
Open

Custom icon only works on ui-gmap-markers and not a singular marker #1408

intellix opened this issue Jul 26, 2015 · 20 comments
Assignees
Milestone

Comments

@intellix
Copy link

Trying to use a custom icon, but can only get it working when using <ui-gmap-markers>. I can see it working on your example, which is confusing as I don't see the difference/cause.

I've created a simple plnkr with both, which highlights the issue: http://plnkr.co/edit/6tKWteGE6iu0pEY9d21F?p=preview

@leocaseiro
Copy link

+1

1 similar comment
@TrickMist
Copy link

+1

@leocaseiro
Copy link

If you set the icon inside options, it works for ui-gmap-marker: http://plnkr.co/edit/2JxtGRoc3jcbf4hM0AA8?p=preview

@solidspark
Copy link
Contributor

I can probably look at this, it's a simple model issue.

@nmccready
Copy link
Contributor

@solidspark thanks

@ecbrodie
Copy link

+1, I am also seeing the icon attribute not working on the marker directive. I have to use options for it. A fix to bring the implementation back to matching the documentation is much appreciated.

@krewmarco
Copy link

wow, I wasted a lot of time on this. How do I vote that this is a priority?

@nmccready
Copy link
Contributor

Why not just use markers?

@leocaseiro
Copy link

marker = 1
marker = 2+

Anyway, as I said before, set the icon inside options. If you just update the documentation, so that would be ok.

@krewmarco
Copy link

Yes, markers work great for this. I just couldn't find it in the docs.

@nmccready
Copy link
Contributor

I am sure this fix is dead simple; is anyone else still looking into the code base for this?

@nmccready nmccready modified the milestone: 2.2.1 Sep 8, 2015
@adyba
Copy link

adyba commented Sep 9, 2015

I don't really care whether custom icon path is defined in marker.icon or marker.option.icon.
It looks so trivial that this undocumented "feature" results in hours of

@nmccready
Copy link
Contributor

lol, I am putting the lines out there so some one else can work on this besides me. So keep banging your head while you wait. Or attempt to solve the issue. I am just trying to help while many complain.

@nmccready
Copy link
Contributor

While your at it document the problem on the wiki, and or website which you can contribute to.

leocaseiro added a commit to leocaseiro/angular-google-maps that referenced this issue Sep 9, 2015
leocaseiro added a commit to leocaseiro/angular-google-maps that referenced this issue Sep 10, 2015
nmccready added a commit that referenced this issue Sep 10, 2015
Fix Issue #1408 Custom Icon which works inside options for single ui-gmap-marker
@nmccready nmccready modified the milestones: 2.2.1, 2.2.2 Sep 11, 2015
@leocaseiro
Copy link

perhaps this issue can be closed

@nmccready
Copy link
Contributor

I can make it work with singular, just got to do it. It's not hard , just gotta find the time.

@nmccready
Copy link
Contributor

So leave it open as an enhancement.

@leocaseiro
Copy link

👍

@nmccready nmccready modified the milestones: 2.2.2, 2.3.1, 2.3.2 Jan 25, 2016
@sameershenai
Copy link

Check your closing element its markers not marker :)
<ui-gmap-marker idKey="marker.id" coords="marker.coords" icon="marker.icon"></ui-gmap-markers>

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

10 participants