Skip to content
This repository has been archived by the owner on Nov 30, 2018. It is now read-only.

infoWindow does not show up via the mouseover event on markers #772

Closed
brian8759 opened this issue Oct 17, 2014 · 7 comments
Closed

infoWindow does not show up via the mouseover event on markers #772

brian8759 opened this issue Oct 17, 2014 · 7 comments
Assignees
Labels
Milestone

Comments

@brian8759
Copy link

Hi,
I am trying to follow the tutorial "issue-74 markers-event" in the example folder.
In the original script, the event is "click", and the "alert window" shows up.
However, I can't make the infoWindow show up via the mouseover event.
Here is the Plunker link
http://plnkr.co/edit/bsqILbPPBJnZwyzeumn8?p=preview

@nmccready nmccready added this to the 2.0.2 milestone Oct 20, 2014
@nmccready
Copy link
Contributor

This works fine your using windows improperly. It expects string expressions and expects show to be show="'show'" . Notice " '

@nmccready
Copy link
Contributor

http://plnkr.co/edit/37qISWsPTlQnENfxc1VE

There might be an issue with showing the window more than once.

@nmccready
Copy link
Contributor

Marking original issue as invalid.

@nmccready
Copy link
Contributor

If you hook to closeClick and set show to false and the setting it to true again on hover then it works. This is because almost all of the watches require the state to change. This could be improved by setting model.show = false on closeClick in markerChild model.

http://plnkr.co/edit/37qISWsPTlQnENfxc1VE

@brian8759
Copy link
Author

Thank you so much.

@nmccready
Copy link
Contributor

Re-opening as this is broken again on master right now

@nmccready nmccready reopened this Dec 3, 2014
@nmccready nmccready modified the milestones: 2.0.12, 2.0.2 Dec 3, 2014
@nmccready
Copy link
Contributor

So the resolution for #946 is in direct conflict for this one. This issue relies on the model being passed around as a reference. Where if the marker model passed through a function is modified it modifies the model in the array. However, #946 depends on clones to be able to differentiate changes (between old and new models).

This line is the issue with _.clone https://github.com/angular-ui/angular-google-maps/blob/master/src/coffee/directives/api/models/parent/markers-parent-model.coffee#L172

nmccready added a commit to nmccready/angular-google-maps that referenced this issue Dec 4, 2014
- This is ripe for a ChildBase Class
This makes angular-ui#946 and angular-ui#772 compatible
@nmccready nmccready added the PR'd label Dec 4, 2014
@nmccready nmccready self-assigned this Dec 4, 2014
@nmccready nmccready removed the PR'd label Dec 4, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants