Skip to content
This repository has been archived by the owner on May 5, 2018. It is now read-only.
This repository has been archived by the owner on May 5, 2018. It is now read-only.

IE Shiv modifications #392

Closed
ProLoser opened this issue Jan 31, 2013 · 1 comment
Closed

IE Shiv modifications #392

ProLoser opened this issue Jan 31, 2013 · 1 comment
Labels
rfc
Milestone
v0.4.0

Comments

@ProLoser
Copy link
Member

We should simplify the shiv and potentially relocate it to it's own module.

Also, I think that there is no point in trying to do IE browser detection INSIDE the shiv. People should just be instructed to use conditional comments.
@ProLoser
Copy link
Member Author

ProLoser commented Feb 1, 2013

Looking for some confirmation before merging this. @ajoslin @petebacondarwin @dandoyon @pkozlowski-opensource do you have any thoughts on if this should be merged?

I felt the instructions for proper use were more than adequate in terms of version checking, and it's not destructive otherwise, and simplicity would make it easier for people to digest our logic.

ProLoser added a commit that referenced this issue Feb 1, 2013
@ProLoser
Merge pull request #395 from angular-ui/shiv
81ab58c 
fix(ieshiv): Removed browser version check and closes #392
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
rfc
Projects
None yet
Milestone
v0.4.0
Development

No branches or pull requests
1 participant
@ProLoser