IE Shiv modifications #392

Closed
ProLoser opened this Issue Jan 31, 2013 · 1 comment

Projects

None yet

1 participant

@ProLoser
Member

We should simplify the shiv and potentially relocate it to it's own module.

Also, I think that there is no point in trying to do IE browser detection INSIDE the shiv. People should just be instructed to use conditional comments.

@ProLoser
Member
ProLoser commented Feb 1, 2013

Looking for some confirmation before merging this. @ajoslin @petebacondarwin @dandoyon @pkozlowski-opensource do you have any thoughts on if this should be merged?

I felt the instructions for proper use were more than adequate in terms of version checking, and it's not destructive otherwise, and simplicity would make it easier for people to digest our logic.

@ProLoser ProLoser closed this in edd05e6 Feb 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment