This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(carousel): resolve rendering issues #4984
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleycho
force-pushed
the
fix/carousel-delay-selection
branch
2 times, most recently
from
ace3787
to
434151f
Compare
- Defer selection of active slide until after transition has been reset to avoid selection occuring before the transition finishes, preventing a new slide from being chosen - Buffer slides if transition is currently going on to navigate to last slide selected after
wesleycho
force-pushed
the
fix/carousel-delay-selection
branch
from
434151f
to
a53fdb7
Compare
wesleycho
changed the title
|
Sounds good to me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to avoid selection occuring before the transition finishes, preventing
a new slide from being chosen
Here is the fix in action for removal of slides - note that the fix works better when the slide removed is not the active slide.
Here is the fix in action for buffering slide changes.
This fixes #4361, #4823 & #4969