Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

carousel breaks on dynamic slide add and scroll #4361

Closed
totano opened this issue Sep 7, 2015 · 3 comments
Closed

carousel breaks on dynamic slide add and scroll #4361

totano opened this issue Sep 7, 2015 · 3 comments

Comments

@totano
Copy link

totano commented Sep 7, 2015

as seen in this plunker, if you add a slide and force scrolling right or left, rendering up.
http://plnkr.co/edit/HnfgQMHXNE2QQdOMFeZl

You can see that also in the demo page (https://angular-ui.github.io/bootstrap/#/carousel),
move on last slide and then quickly click the Add Slide button and then the carousel next control arrow,
the UI will flicker and then the carousel will become unresponsive.

As a temporary fix I'm using $timeout after setting the active property

@wesleycho
Copy link
Contributor

This appears to be a bug when on the last slide - is this correct?

@totano
Copy link
Author

totano commented Sep 8, 2015

this happens when on the edge slide (both last and first) after adding a new slide and advancing the carousel, both manually (setting active to false on the current slide, and true on the following) or clicking carousel prev/next controls.

@wesleycho wesleycho modified the milestones: 0.14.3, 1.0.0 Oct 23, 2015
@wesleycho
Copy link
Contributor

This will be fixed by #4984, as can be seen here

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants