Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

feat(modal): Adding model sizes as config option. sizeClass #1885

Closed
wants to merge 1 commit into from

Conversation

cleargif
Copy link

@cleargif cleargif commented Mar 3, 2014

I am using this on a current project and thought I would do a PR.

As per http://getbootstrap.com/javascript/#modals-sizes it will allow the size of the model to be set as described by TBS3.

@maxcan
Copy link

maxcan commented Mar 29, 2014

this would be really helpful for us. any hold up on getting it merged?

@Foxandxss
Copy link
Contributor

Time, that is the hold up. I like what I see, but it is not up to me.

@chrisirhc
Copy link
Contributor

Looks good to me, actually. Added this to milestone for next release.

I guess the alternative is to add any arbitrary attribute needed (such as sizeClass) through resolve and then modify the template to pick up the property from the resolved attributes. Another alternative is to allow per-modal customization of the template.

@chrisirhc chrisirhc added this to the 0.11.0 milestone Apr 2, 2014
@chrisirhc
Copy link
Contributor

May want to name this as modalClass or dialogClass though, as this isn't necessarily restricted to size classes but any class that the user would like to apply to the modal-dialog element.

@cleargif
Copy link
Author

cleargif commented Apr 2, 2014

@chrisirhc are you asking that I rename the class - point taken that you use it for any class you want.

will make the change as soon as I can. I am in South Africa with very limited access to an internet connection :(

@GiorgioPingendo
Copy link

I need too....Thank you very much.

@bekos
Copy link
Contributor

bekos commented Apr 15, 2014

My 2¢ here. I think that since bootstrap supports the size as option, we should also have one dedicated option for this, ie size: "sm|lg" and the class in modal something like 'modal-' + size. All the other customisation should be allowed by overriding the template per modal, because we cannot supports this way all the custom attributes someone may want to add or alter.

@pkozlowski-opensource
Copy link
Member

+1 for @bekos suggestion, I think we should stick to an attribute name that doesn't suggest any CSS classes. Size sounds good for a quick fix.

@pkozlowski-opensource
Copy link
Member

@cleargif many thnx for this pull request but I would rather take the direction of #2084.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants