-
Notifications
You must be signed in to change notification settings - Fork 6.7k
feat(modal): Adding model sizes as config option. sizeClass #1885
Conversation
this would be really helpful for us. any hold up on getting it merged? |
Time, that is the hold up. I like what I see, but it is not up to me. |
Looks good to me, actually. Added this to milestone for next release. I guess the alternative is to add any arbitrary attribute needed (such as |
May want to name this as modalClass or dialogClass though, as this isn't necessarily restricted to size classes but any class that the user would like to apply to the modal-dialog element. |
@chrisirhc are you asking that I rename the class - point taken that you use it for any class you want. will make the change as soon as I can. I am in South Africa with very limited access to an internet connection :( |
I need too....Thank you very much. |
My 2¢ here. I think that since bootstrap supports the size as option, we should also have one dedicated option for this, ie |
+1 for @bekos suggestion, I think we should stick to an attribute name that doesn't suggest any CSS classes. Size sounds good for a quick fix. |
I am using this on a current project and thought I would do a PR.
As per http://getbootstrap.com/javascript/#modals-sizes it will allow the size of the model to be set as described by TBS3.