feat($modal): support modal window sizes

[gazoakley]

Following on from comments by @bekos in #1885 this pull request allows specifying a size of either sm or lg when creating a modal dialog

[pkozlowski-opensource]

@gazoakley thnx for this PR, I like the direction it is taking! I would like to ask you for 2 changes, though:

• could we pass all the way down the size property to the modal window template and calculate the actual class in the template itself? This way people can use modals with any markup, not only bootstrap's one;
• we will need some tests to prove that this new functionality works correctly.

Could you please do those changes and squash the commits afterwards? Thank you!

[bekos]

@gazoakley I don't know if I help, but for the template expression that @pkozlowski-opensource is talking about you can use something like: ng-class="{'modal-{{size}}': size}

[gazoakley]

@bekos I like the conciseness of that, but unfortunately Angular ended up appending the class as 'modal-' instead of 'modal-sm' or 'modal-lg'. At the moment I'm using ng-class="{'modal-sm': size == 'sm', 'modal-lg': size == 'lg'}" - not so pretty but it works.

[gazoakley]

If people are happy with these changes let me know and I'll squash the commit.

[pkozlowski-opensource]

LGTM. Please squash commits. Also it would be great if the commit message follow our convention, sth like: feat($modal): support modal window sizes

[gazoakley]

All done. Let me know if you'd like anything changed.

[pkozlowski-opensource]

Thnx @gazoakley, your commit looks good now. But it looks like it is not based on the latest master as it doesn't merge cleanly. Will try to merge manually later on, but if you could rebase it on top of the latest master it would be helpful.

[gazoakley]

Tidying this now.

[gazoakley]

Should all be GTG.

[pkozlowski-opensource]

@gazoakley thnx, it landed! Much appreciated!