fix: 🐛 ensure viewport height cannot be negative

Closes: #3034
angular-ui · Aug 7, 2021 · a7111a1 · a7111a1
1 parent c9abb8b
commit a7111a1
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/packages/cellnav/test/uiGridCellNavService.spec.js b/packages/cellnav/test/uiGridCellNavService.spec.js
@@ -201,7 +201,7 @@ describe('ui.grid.edit uiGridCellNavService', function() {
 			$timeout.flush();
 
 			expect(args.grid).toEqual(grid);
-			expect(Math.round(args.y.percentage * 10) / 10).toBe(0.4);
+			expect(Math.round(args.y.percentage * 10) / 10).toBe(0.5);
 			expect(isNaN(args.x.percentage)).toEqual(true);
 		});
 
@@ -233,7 +233,7 @@ describe('ui.grid.edit uiGridCellNavService', function() {
 			});
 			$timeout.flush();
 
-			expect(Math.round(args.y.percentage * 10) / 10).toEqual(0.5);
+			expect(Math.round(args.y.percentage * 10) / 10).toEqual(0.6);
 			expect(args.x).toBe(null);
 		});
 

diff --git a/packages/core/src/js/factories/Grid.js b/packages/core/src/js/factories/Grid.js
@@ -1685,7 +1685,7 @@ angular.module('ui.grid')
 
     // gridUtil.logDebug('viewPortHeight', viewPortHeight);
 
-    return viewPortHeight;
+    return viewPortHeight > 0 ? viewPortHeight : 0;
   };
 
   Grid.prototype.getViewportWidth = function getViewportWidth() {

diff --git a/packages/core/src/js/factories/GridRenderContainer.js b/packages/core/src/js/factories/GridRenderContainer.js
@@ -229,7 +229,7 @@ angular.module('ui.grid')
 
     viewPortHeight = viewPortHeight + adjustment.height;
 
-    return viewPortHeight;
+    return viewPortHeight > 0 ? viewPortHeight : 0;
   };
 
   GridRenderContainer.prototype.getViewportWidth = function getViewportWidth() {