-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Closed
Description
We've run into an issue where it is possible to resize a grid such that the getViewportHeight() method returns a negative value (basically anytime the gridHeight is less than the headerHeight).
Granted, this is an edge case but it would be nice if ui-grid could protect against this since a negative value is not valid for the CSS height property.
Seems like this should be beyond trivial (return (viewPortHeight > 0) ? viewPortHeight : 0;
) in both getViewportHeight methods, but I'm not familiar with the ui-grid code so I don't know all the implications of changing this.