Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column menu not positioned correctly with animations on #1753

Closed
wattsbn opened this issue Oct 7, 2014 · 1 comment
Closed

Column menu not positioned correctly with animations on #1753

wattsbn opened this issue Oct 7, 2014 · 1 comment

Comments

@wattsbn
Copy link
Contributor

wattsbn commented Oct 7, 2014

I am seeing the column menus not being positioned correctly in my app. Sometimes up to 50px too far to the left. This is quite the weird bug, but I finally figured out what was causing it. If I turn off $animate, the issue goes away.

Just by looking at the example in the docs (303), you don't see the issue (maybe because the default width is correct in that case. However, if you edit that example in plunker, you will see the issue on the column menu for the company column.

I believe the problem is that there is a timeout that is being used that assumes that the menu is shown by the time its callback is being called. However, with animations on, this assumption is usually wrong.
$timeout( $scope.repositionMenuClosure( $scope, column, colElementPosition, $elm, $columnElement ), 10);

@wattsbn
Copy link
Contributor Author

wattsbn commented Oct 7, 2014

@PaulL1 Seeing as you have just recently refactored a lot of this code, I figured you might know how to fix this. Hopefully its an easy fix. Let me know if you have problems reproducing the issue.

@PaulL1 PaulL1 closed this as completed in a78b9fd Oct 7, 2014
PaulL1 added a commit that referenced this issue Oct 7, 2014
Fix #1753 (colMenu): size correctly with animations, hide on scroll or d...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant