Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column moving issues #1815

Closed
c0bra opened this issue Oct 14, 2014 · 7 comments
Closed

Column moving issues #1815

c0bra opened this issue Oct 14, 2014 · 7 comments
Milestone

Comments

@c0bra
Copy link
Contributor

c0bra commented Oct 14, 2014

There's a few minor issues with column moving:

  • The column element gets cloned on-click, so if you click the column header to sort it you get what looks like a weird shadow effect. It should only clone the element once the mouse has been dragged a certain number of pixels.
  • The column menu now displays on-click, no matter what
  • While the grid menu gets hidden when the column is dragged, if you drag, then wait, it will show. The feature should probably prevent the column menu from showing by catching the event in the case that a column is being dragged.
  • This feature is also affected by this bug: [3.0][Column Resize] Column resize function works incorrectly after hiding columns #1697
@c0bra c0bra modified the milestones: Future, 3.0 Oct 14, 2014
@OrenHasbani
Copy link

go to: http://plnkr.co/edit/GRDSonyeetWsTkpC76xn?p=preview (THE demo plunker for column-moving feature)

In both browsers IE and FireFox the feature doesn't work.

@jpuri
Copy link
Contributor

jpuri commented Nov 6, 2014

I was much busy last couple of days. I plan to soon spare time to fix these issues.

jpuri pushed a commit to jpuri/ng-grid that referenced this issue Nov 6, 2014
jpuri pushed a commit to jpuri/ng-grid that referenced this issue Nov 6, 2014
PaulL1 added a commit that referenced this issue Nov 6, 2014
Fix for issues #2014 and partially #1815
jpuri added a commit to jpuri/ng-grid that referenced this issue Nov 10, 2014
jpuri added a commit to jpuri/ng-grid that referenced this issue Nov 16, 2014
jpuri pushed a commit to jpuri/ng-grid that referenced this issue Nov 24, 2014
@jpuri jpuri mentioned this issue Nov 24, 2014
@jpuri
Copy link
Contributor

jpuri commented Nov 24, 2014

PR #2212, should fixed 1st and 4th issue mentioned by @c0bra above, I could not replicate 2nd and 3rd issue.

There is still one outstanding issue, moving column does not shows up in IE, although its redrawn at correct position after being dropped.

swalters added a commit that referenced this issue Dec 1, 2014
jpuri added a commit to jpuri/ng-grid that referenced this issue Dec 2, 2014
jpuri pushed a commit to jpuri/ng-grid that referenced this issue Dec 2, 2014
@c0bra
Copy link
Contributor Author

c0bra commented Dec 8, 2014

@jpuri there is now a new issue; not sure if it's been reported anywhere. The cloned element gets created on-click.

To reproduce:

  1. Go here: http://ui-grid.info/docs/#/tutorial/310_column_moving
  2. Click on the "Id" column to sort.
  3. Move your cursor left and right in the header

You will see the cloned "draggable" element following your cursor but it shouldn't be there since you haven't held down your mouse to drag it.

@jpuri
Copy link
Contributor

jpuri commented Dec 9, 2014

Hi @c0bra , I know this issue has appeared because of some of my changes. Fix for this is already there in PR #2265.

@jpuri
Copy link
Contributor

jpuri commented Dec 15, 2014

Only 1 issue in the lists above is outstanding, that is support for move column in IE. I have created a separate issue for that #2352.

@c0bra , @PaulL1 this issue can be closed now.

@PaulL1
Copy link
Contributor

PaulL1 commented Dec 15, 2014

Thanks @jpuri.

@PaulL1 PaulL1 closed this as completed Dec 15, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants