Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encountered several issues with ui-grid rc20 #3373

Closed
rroy2 opened this issue Apr 28, 2015 · 4 comments
Closed

encountered several issues with ui-grid rc20 #3373

rroy2 opened this issue Apr 28, 2015 · 4 comments
Assignees
Milestone

Comments

@rroy2
Copy link

rroy2 commented Apr 28, 2015

I created a grid contains an editable dropdown and another column that contains a checkbox. I use ui-grid-pagination ui-grid-cellNav ui-grid-pinning ui-grid-edit. I also set enableCellEditOnFocus: true.

Issue 1: after tabbing into the dropdown column, the dropdown appears and has focus. The problem is that I can't tab out. I have to hit escape to close the dropdown first. Shift+tab does work however.

Issue 2: I use cellTemplate in order to display a checkbox instead of the words "true" or "false". The problem with using a cellTemplate is that when tabbing into (or clicking) the cell in that column, the checkbox gets focus but the cell does not change it's background color. I just used a cellTemplate I found in a lot of places on the internet and that is: cellTemplate: ''
Do I need to do something different for the cellTemplate to get cell highlighting to work?

@rroy2
Copy link
Author

rroy2 commented Apr 28, 2015

Never mind about issue 1. The problem was caused by this code
onRegisterApi: function(gridApi) {
$scope.gridApi = gridApi;
gridApi.edit.on.afterCellEdit($scope, function(rowEntity, colDef, newValue, oldValue) {
$scope.lastCellEdited = 'edited row id:' + rowEntity.id + ' Column:' + colDef.name + ' newValue:' + newValue + ' oldValue:' + oldValue ;
$scope.$apply();
});

@rroy2
Copy link
Author

rroy2 commented Apr 29, 2015

Issue 2 has been resolved in RC21 but a new issue has arose.
When navigating into a checkbox cell, the cell background hightlights but pressing spacebar no longer checks/unchecks the checkbox.

Another issue I've seen is that for a dropdown, changes made with the keyboard does not take effect. Tabbing out of the cell reverts any changes made.

@PaulL1
Copy link
Contributor

PaulL1 commented May 15, 2015

@swalters: assigning to you to have an opinion on. I think this is really telling us that we've still got gremlins in edit, which I think we know, setting this to hi-pri so that we don't lose that.

@PaulL1 PaulL1 added this to the 3.0 milestone May 15, 2015
@swalters
Copy link
Contributor

dropdown tab fixed with 2edc4d6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants