Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

Commit

Permalink
fix(autocomplete): change to type="search"
Browse files Browse the repository at this point in the history
- Change inputs to `type="search"`
- Change to `autocomplete="off"` as per HTML spec

Closes #991
  • Loading branch information
ruipenso authored and wesleycho committed Apr 6, 2016
1 parent 4b1ed47 commit 48cf1ba
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions src/bootstrap/select-multiple.tpl.html
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
<div class="ui-select-container ui-select-multiple ui-select-bootstrap dropdown form-control" ng-class="{open: $select.open}">
<div>
<div class="ui-select-match"></div>
<input type="text"
<input type="search"
autocomplete="off"
autocorrect="off"
autocapitalize="off"
spellcheck="false"
spellcheck="false"
class="ui-select-search input-xs"
placeholder="{{$selectMultiple.getPlaceholder()}}"
ng-disabled="$select.disabled"
Expand Down
2 changes: 1 addition & 1 deletion src/bootstrap/select.tpl.html
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<div class="ui-select-container ui-select-bootstrap dropdown" ng-class="{open: $select.open}">
<div class="ui-select-match"></div>
<input type="text" autocomplete="off" tabindex="-1"
<input type="search" autocomplete="off" tabindex="-1"
aria-expanded="true"
aria-label="{{ $select.baseTitle }}"
aria-owns="ui-select-choices-{{ $select.generatedId }}"
Expand Down
2 changes: 1 addition & 1 deletion src/select2/select-multiple.tpl.html
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<span class="ui-select-match"></span>
<li class="select2-search-field">
<input
type="text"
type="search"
autocomplete="off"
autocorrect="off"
autocapitalize="off"
Expand Down
2 changes: 1 addition & 1 deletion src/select2/select.tpl.html
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<div class="ui-select-dropdown select2-drop select2-with-searchbox select2-drop-active"
ng-class="{'select2-display-none': !$select.open}">
<div class="select2-search" ng-show="$select.searchEnabled">
<input type="text" autocomplete="off" autocorrect="false" autocapitalize="off" spellcheck="false"
<input type="search" autocomplete="off" autocorrect="off" autocapitalize="off" spellcheck="false"
role="combobox"
aria-expanded="true"
aria-owns="ui-select-choices-{{ $select.generatedId }}"
Expand Down
2 changes: 1 addition & 1 deletion src/selectize/select.tpl.html
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
ng-class="{'focus': $select.open, 'disabled': $select.disabled, 'selectize-focus' : $select.focus}"
ng-click="$select.open && !$select.searchEnabled ? $select.toggle($event) : $select.activate()">
<div class="ui-select-match"></div>
<input type="text" autocomplete="off" tabindex="-1"
<input type="search" autocomplete="off" tabindex="-1"
class="ui-select-search ui-select-toggle"
ng-click="$select.toggle($event)"
placeholder="{{$select.placeholder}}"
Expand Down

0 comments on commit 48cf1ba

Please sign in to comment.