This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
Adding fixes mainly to tagging functionality #1371
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the ddl and then deleting it causes the (tag new item) to persists
…y sets the new tag but keeps the search input value
…hen using tagging where each tag is an object) already exists in the list
…ightVisible is called using a timeout
…elay, the keyup event fires before or after the 'refresh' (attr) method. added a fix to implement the refresh-delay for the keyup event as well
…ists in the list of tags
This was referenced Feb 9, 2016
angular-ui#1298) remove opacity change in dist fix lost focus (on backspace or adding new tag) when append-to-body is used fixing bug - when typing a letter that exists in one of the items in the ddl and then deleting it causes the (tag new item) to persists fix bug: when using closeOnSelect with tagging - hitting the enter key sets the new tag but keeps the search input value tagging: --making sure no empty elements gets in on paste operation --fix dupes search added isNewTagDuplication optional user method to check if new tag (when using tagging where each tag is an object) already exists in the list adding safety check that the control is still open cause _ensureHighlightVisible is called using a timeout adding public to gitignore ignoring public folder fix tagging: when using 'tagging' (add tags on the fly) with refreshDelay, the keyup event fires before or after the 'refresh' (attr) method. added a fix to implement the refresh-delay for the keyup event as well making sure new tag (tag added on the fly) is removed when already exists in the list of tags fix bug when filtering reverting back list folder (before fork state)
* 'master' of https://github.com/onemenny/ui-select: fix bug when filtering making sure new tag (tag added on the fly) is removed when already exists in the list of tags fix tagging: when using 'tagging' (add tags on the fly) with refreshDelay, the keyup event fires before or after the 'refresh' (attr) method. added a fix to implement the refresh-delay for the keyup event as well ignoring public folder adding public to gitignore adding safety check that the control is still open cause _ensureHighlightVisible is called using a timeout added isNewTagDuplication optional user method to check if new tag (when using tagging where each tag is an object) already exists in the list tagging: --making sure no empty elements gets in on paste operation --fix dupes search fix bug: when using closeOnSelect with tagging - hitting the enter key sets the new tag but keeps the search input value fixing bug - when typing a letter that exists in one of the items in the ddl and then deleting it causes the (tag new item) to persists fix lost focus (on backspace or adding new tag) when append-to-body is used test remove opacity change in dist disable opacity set to zero cause of flickering when typing in ddl see (angular-ui#1298)
|
This needs work - there should be no changes to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added isNewTagDuplication optional user method to check if new tag (when using tagging where each tag is an object) already exists in the list
tagging: making sure no empty elements gets in on paste operation
fix bug: when using closeOnSelect with tagging - hitting the enter key sets the new tag but keeps the search input value
fixing bug - when typing a letter that exists in one of the items in the ddl and then deleting it causes the (tag new item) to persists
fix lost focus (on backspace or adding new tag) when append-to-body is used
remove opacity changes - that causes flickering (#1298) (#1298)