This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
fix(uiSelectCtrl): correcting input focus #1517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected input focus when ui-select contains no elements. Also corrected a memory leaked caused by event handlers never being removed. Closes angular-ui#1253
|
This PR corrects two issues:
|
|
@wesleycho any chance you could review this if/when you get a chance? I don't have any experience with angular animate. |
| // Only focus input after the animation has finished | ||
| $timeout(function () { | ||
| ctrl.$animate.off('removeClass', searchInput[0], animateHandler); |
There was a problem hiding this comment.
I don't think this needs to be in the $timeout
Moved the removal of activate events out of the $timeout. This removes additional unneccessary calls to the event handler once the $timeout has been initiated.
|
Just chiming in that it would be awesome to see this fix in the next release! |
|
This LGTM @user378230 - feel free to merge, unless you feel like this needs a test. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrected input focus when ui-select contains no elements. Also corrected a memory leaked caused by event handlers never being removed.
Closes #1253