This repository has been archived by the owner on Oct 2, 2019. It is now read-only.
Skip disabled items while navigating with keyboard #1823
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user378230
reviewed
Oct 25, 2016
| else if (ctrl.activeIndex < ctrl.items.length - 1) { | ||
| var newIndex = ctrl.activeIndex + 1; | ||
| while (_isItemDisabled(ctrl.items[newIndex]) && newIndex < ctrl.items.length) | ||
| newIndex++; |
There was a problem hiding this comment.
Could we increment and compare in the while expression? To save repeating the condition inside it.
user378230
reviewed
Oct 25, 2016
| else if (ctrl.activeIndex > 0 || (ctrl.search.length === 0 && ctrl.tagging.isActivated && ctrl.activeIndex > -1)) { | ||
| var newIndex = ctrl.activeIndex - 1; | ||
| while (_isItemDisabled(ctrl.items[newIndex]) && newIndex >= 0) | ||
| newIndex--; |
There was a problem hiding this comment.
Similar to the other comment, to save on duplication of checks
|
@Seprum this looks very useful! But it does need unit tests before it can be merged. 😥 Any chance you could add some? 😃 |
|
@Jefiozie you might like to pick this one up with tests etc. if you feel like it. I think it seems like a reasonable change. |
|
@user378230 , you want me to implement this fix? |
|
@Jefiozie Only if you want to! It looks fairly easy and makes sense, so thought you might like it 😝 (You can just open a new PR) |
|
@user378230 , see my PR 👍 |
|
Closing pr as handeld by other PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When user presses up/down keys within dropdown, disabled items become active too. It has no visual effect but still is a bit confusing. I have added check for disabled items insted of plain incrementing/decrementing
activeIndexvalue.