Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

fix highlight when using animate #2063

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gboros
Copy link

@gboros gboros commented Oct 13, 2017

when animate is used, the dropdown is not scrolled to the selected item - this commit calls "_ensureHighlightVisible" in this case, to fix it

@Jefiozie
Copy link
Contributor

HI @gboros can you show a working an non working example for me?
So I can see what the original problem is ,thanks

@gboros
Copy link
Author

gboros commented Oct 18, 2017

hi
here is a non-working example : https://plnkr.co/edit/TWDf59jpdY7UuFf3BtTI?p=preview The dropdown should scroll to 'eleven'. If you change to use the 'select-fixed.js', that contains the PR, it will scroll

Copy link
Contributor

@Jefiozie Jefiozie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make a test for this? So that future adjustments won’t break.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants