Skip to content

Commit

Permalink
refactor(@angular-devkit/build-angular): deprecate hmrWarning and ser…
Browse files Browse the repository at this point in the history
…vePathDefaultWarning options

With this change we deprecate servePathDefaultWarning and hmrWarning which no longer has an effect.

Using any unsupported deploy-url or base-href serve path value will result in a hard warning.
  • Loading branch information
alan-agius4 authored and clydin committed Oct 7, 2020
1 parent f33d10d commit 290fe43
Showing 1 changed file with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -463,8 +463,7 @@ export function buildServePath(
let servePath = serverOptions.servePath;
if (!servePath && servePath !== '') {
const defaultPath = _findDefaultServePath(browserOptions.baseHref, browserOptions.deployUrl);
const showWarning = serverOptions.servePathDefaultWarning;
if (defaultPath == null && showWarning) {
if (defaultPath == null) {
logger.warn(tags.oneLine`
Warning: --deploy-url and/or --base-href contain unsupported values for ng serve. Default
serve path of '/' used. Use --serve-path to override.
Expand Down

0 comments on commit 290fe43

Please sign in to comment.