-
Notifications
You must be signed in to change notification settings - Fork 12k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(@angular-devkit/build-angular): avoid CommonJS warning for zone.j…
…s in esbuild The `zone.js` package is currently built into a module structure form that resembles UMD-like output. This causes the CommonJS checker within the experimental esbuild-based browser application builder to issue a warning for `zone.js` usage. Until the packaging of `zone.js` is updated to become fully ESM, the `zone.js` package is automatically allowed when performing the CommonJS module check.
- Loading branch information
1 parent
afcc49f
commit 421417a
Showing
5 changed files
with
181 additions
and
11 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
163 changes: 163 additions & 0 deletions
163
...angular/src/builders/browser-esbuild/tests/options/allowed-common-js-dependencies_spec.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,163 @@ | ||
| /** | ||
| * @license | ||
| * Copyright Google LLC All Rights Reserved. | ||
| * | ||
| * Use of this source code is governed by an MIT-style license that can be | ||
| * found in the LICENSE file at https://angular.io/license | ||
| */ | ||
|
|
||
| import { logging } from '@angular-devkit/core'; | ||
| import { buildEsbuildBrowser } from '../../index'; | ||
| import { BASE_OPTIONS, BROWSER_BUILDER_INFO, describeBuilder } from '../setup'; | ||
|
|
||
| describeBuilder(buildEsbuildBrowser, BROWSER_BUILDER_INFO, (harness) => { | ||
| describe('Option: "allowedCommonJsDependencies"', () => { | ||
| describe('given option is not set', () => { | ||
| for (const aot of [true, false]) { | ||
| it(`should show warning when depending on a Common JS bundle in ${ | ||
| aot ? 'AOT' : 'JIT' | ||
| } Mode`, async () => { | ||
| // Add a Common JS dependency | ||
| await harness.appendToFile('src/app/app.component.ts', `import 'buffer';`); | ||
|
|
||
| harness.useTarget('build', { | ||
| ...BASE_OPTIONS, | ||
| allowedCommonJsDependencies: [], | ||
| optimization: true, | ||
| aot, | ||
| }); | ||
|
|
||
| const { result, logs } = await harness.executeOnce(); | ||
|
|
||
| expect(result?.success).toBe(true); | ||
| expect(logs).toContain( | ||
| jasmine.objectContaining<logging.LogEntry>({ | ||
| message: jasmine.stringMatching( | ||
| /Module 'buffer' used by 'src\/app\/app\.component\.ts' is not ESM/, | ||
| ), | ||
| }), | ||
| ); | ||
| expect(logs).toContain( | ||
| jasmine.objectContaining<logging.LogEntry>({ | ||
| message: jasmine.stringMatching(/CommonJS or AMD dependencies/), | ||
| }), | ||
| ); | ||
| expect(logs).not.toContain( | ||
| jasmine.objectContaining<logging.LogEntry>({ | ||
| message: jasmine.stringMatching('base64-js'), | ||
| }), | ||
| 'Should not warn on transitive CommonJS packages which parent is also CommonJS.', | ||
| ); | ||
| }); | ||
| } | ||
| }); | ||
|
|
||
| it('should not show warning when depending on a Common JS bundle which is allowed', async () => { | ||
| // Add a Common JS dependency | ||
| await harness.appendToFile( | ||
| 'src/app/app.component.ts', | ||
| ` | ||
| import 'buffer'; | ||
| `, | ||
| ); | ||
|
|
||
| harness.useTarget('build', { | ||
| ...BASE_OPTIONS, | ||
| allowedCommonJsDependencies: ['buffer', 'base64-js', 'ieee754'], | ||
| optimization: true, | ||
| }); | ||
|
|
||
| const { result, logs } = await harness.executeOnce(); | ||
|
|
||
| expect(result?.success).toBe(true); | ||
| expect(logs).not.toContain( | ||
| jasmine.objectContaining<logging.LogEntry>({ | ||
| message: jasmine.stringMatching(/CommonJS or AMD dependencies/), | ||
| }), | ||
| ); | ||
| }); | ||
|
|
||
| it('should not show warning when depending on zone.js', async () => { | ||
| // Add a Common JS dependency | ||
| await harness.appendToFile( | ||
| 'src/app/app.component.ts', | ||
| ` | ||
| import 'zone.js'; | ||
| `, | ||
| ); | ||
|
|
||
| harness.useTarget('build', { | ||
| ...BASE_OPTIONS, | ||
| allowedCommonJsDependencies: [], | ||
| optimization: true, | ||
| }); | ||
|
|
||
| const { result, logs } = await harness.executeOnce(); | ||
|
|
||
| expect(result?.success).toBe(true); | ||
| expect(logs).not.toContain( | ||
| jasmine.objectContaining<logging.LogEntry>({ | ||
| message: jasmine.stringMatching(/CommonJS or AMD dependencies/), | ||
| }), | ||
| ); | ||
| }); | ||
|
|
||
| it(`should not show warning when importing non global local data '@angular/common/locale/fr'`, async () => { | ||
| await harness.appendToFile( | ||
| 'src/app/app.component.ts', | ||
| `import '@angular/common/locales/fr';`, | ||
| ); | ||
|
|
||
| harness.useTarget('build', { | ||
| ...BASE_OPTIONS, | ||
| allowedCommonJsDependencies: [], | ||
| optimization: true, | ||
| }); | ||
|
|
||
| const { result, logs } = await harness.executeOnce(); | ||
|
|
||
| expect(result?.success).toBe(true); | ||
| expect(logs).not.toContain( | ||
| jasmine.objectContaining<logging.LogEntry>({ | ||
| message: jasmine.stringMatching(/CommonJS or AMD dependencies/), | ||
| }), | ||
| ); | ||
| }); | ||
|
|
||
| it('should not show warning in JIT for templateUrl and styleUrl when using paths', async () => { | ||
| await harness.modifyFile('tsconfig.json', (content) => { | ||
| return content.replace( | ||
| /"baseUrl": ".\/",/, | ||
| ` | ||
| "baseUrl": "./", | ||
| "paths": { | ||
| "@app/*": [ | ||
| "src/app/*" | ||
| ] | ||
| }, | ||
| `, | ||
| ); | ||
| }); | ||
|
|
||
| await harness.modifyFile('src/app/app.module.ts', (content) => | ||
| content.replace('./app.component', '@app/app.component'), | ||
| ); | ||
|
|
||
| harness.useTarget('build', { | ||
| ...BASE_OPTIONS, | ||
| allowedCommonJsDependencies: [], | ||
| optimization: true, | ||
| aot: false, | ||
| }); | ||
|
|
||
| const { result, logs } = await harness.executeOnce(); | ||
|
|
||
| expect(result?.success).toBe(true); | ||
| expect(logs).not.toContain( | ||
| jasmine.objectContaining<logging.LogEntry>({ | ||
| message: jasmine.stringMatching(/CommonJS or AMD dependencies/), | ||
| }), | ||
| ); | ||
| }); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters