fix(@angular-devkit/build-angular): Set chunk names explicitly

Explicitly set chunk name pattern to exclude them from Jest run
angular · Jul 14, 2023 · 5048f6e · 5048f6e
1 parent 5908ede
commit 5048f6e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/packages/angular_devkit/build_angular/src/tools/esbuild/application-code-bundle.ts b/packages/angular_devkit/build_angular/src/tools/esbuild/application-code-bundle.ts
@@ -251,6 +251,7 @@ function getEsBuildCommonOptions(options: NormalizedApplicationBuildOptions): Bu
     outExtension: outExtension ? { '.js': `.${outExtension}` } : undefined,
     sourcemap: sourcemapOptions.scripts && (sourcemapOptions.hidden ? 'external' : true),
     splitting: true,
+    chunkNames: 'chunk-[hash]',
     tsconfig,
     external: externalDependencies,
     write: false,

diff --git a/tests/legacy-cli/e2e/tests/basic/rebuild.ts b/tests/legacy-cli/e2e/tests/basic/rebuild.ts
@@ -1,13 +1,13 @@
-import { waitForAnyProcessOutputToMatch, silentNg } from '../../utils/process';
-import { writeFile, writeMultipleFiles } from '../../utils/fs';
 import fetch from 'node-fetch';
-import { ngServe } from '../../utils/project';
 import { getGlobalVariable } from '../../utils/env';
+import { writeFile, writeMultipleFiles } from '../../utils/fs';
+import { silentNg, waitForAnyProcessOutputToMatch } from '../../utils/process';
+import { ngServe } from '../../utils/project';
 
 export default async function () {
   const esbuild = getGlobalVariable('argv')['esbuild'];
   const validBundleRegEx = esbuild ? /complete\./ : /Compiled successfully\./;
-  const lazyBundleRegEx = esbuild ? /lazy\.module/ : /lazy_module_ts\.js/;
+  const lazyBundleRegEx = esbuild ? /chunk-/ : /lazy_module_ts\.js/;
 
   const port = await ngServe();
   // Add a lazy module.
@@ -17,6 +17,7 @@ export default async function () {
   // We need to use Promise.all to ensure we are waiting for the rebuild just before we write
   // the file, otherwise rebuilds can be too fast and fail CI.
   // Count the bundles.
+  // Verify that a new chunk was created.
   await Promise.all([
     waitForAnyProcessOutputToMatch(lazyBundleRegEx),
     writeFile(