Skip to content

Commit

Permalink
fix(@angular/cli): don't display prompts twice
Browse files Browse the repository at this point in the history
Closes #19027
  • Loading branch information
alan-agius4 authored and filipesilva committed Oct 13, 2020
1 parent 49199ce commit 5318e4c
Showing 1 changed file with 10 additions and 3 deletions.
13 changes: 10 additions & 3 deletions packages/angular/cli/models/schematic-command.ts
Expand Up @@ -311,6 +311,16 @@ export abstract class SchematicCommand<
workflow.registry.addSmartDefaultProvider('projectName', getProjectName);
workflow.registry.useXDeprecatedProvider(msg => this.logger.warn(msg));

let shouldReportAnalytics = true;
workflow.engineHost.registerOptionsTransform(async (_, options) => {
if (shouldReportAnalytics) {
shouldReportAnalytics = false;
await this.reportAnalytics([this.description.name], options as Arguments);
}

return options;
});

if (options.interactive !== false && isTTY()) {
workflow.registry.usePromptProvider((definitions: Array<schema.PromptDefinition>) => {
const questions: inquirer.QuestionCollection = definitions
Expand Down Expand Up @@ -481,9 +491,6 @@ export abstract class SchematicCommand<
...options.additionalOptions,
};

const transformOptions = await workflow.engine.transformOptions(schematic, input).toPromise();
await this.reportAnalytics([this.description.name], transformOptions as Arguments);

workflow.reporter.subscribe((event: DryRunEvent) => {
nothingDone = false;

Expand Down

0 comments on commit 5318e4c

Please sign in to comment.