feat(@angular-devkit/build-angular): default to NodeJS value for pres…

…erveSymlinks
angular · Jan 17, 2020 · 6105bf4 · 6105bf4
1 parent 30df147
commit 6105bf4
Show file tree

Hide file tree

Showing 9 changed files with 13 additions and 19 deletions.
diff --git a/docs/documentation/build.md b/docs/documentation/build.md
@@ -304,7 +304,7 @@ See https://github.com/angular/angular-cli/issues/7797 for details.
     <code>--preserve-symlinks</code>
   </p>
   <p>
-    Do not use the real path when resolving modules.
+    Do not use the real path when resolving modules. If unset then will default to `true` if NodeJS option --preserve-symlinks is set.
   </p>
 </details>
 <details>

diff --git a/docs/documentation/test.md b/docs/documentation/test.md
@@ -123,7 +123,7 @@ You can run tests with coverage via `--code-coverage`. The coverage report will
     <code>--preserve-symlinks</code>
   </p>
   <p>
-    Do not use the real path when resolving modules.
+    Do not use the real path when resolving modules. If unset then will default to `true` if NodeJS option --preserve-symlinks is set.
   </p>
 </details>
 <details>

diff --git a/packages/angular/cli/lib/config/schema.json b/packages/angular/cli/lib/config/schema.json
@@ -844,8 +844,7 @@
             },
             "preserveSymlinks": {
               "type": "boolean",
-              "description": "Do not use the real path when resolving modules.",
-              "default": false
+              "description": "Do not use the real path when resolving modules. If unset then will default to `true` if NodeJS option --preserve-symlinks is set."
             },
             "extractLicenses": {
               "type": "boolean",
@@ -1478,8 +1477,7 @@
             },
             "preserveSymlinks": {
               "type": "boolean",
-              "description": "Do not use the real path when resolving modules.",
-              "default": false
+              "description": "Do not use the real path when resolving modules. If unset then will default to `true` if NodeJS option --preserve-symlinks is set."
             },
             "browsers": {
               "type": "string",
@@ -1855,8 +1853,7 @@
             },
             "preserveSymlinks": {
               "type": "boolean",
-              "description": "Do not use the real path when resolving modules.",
-              "default": false
+              "description": "Do not use the real path when resolving modules. If unset then will default to `true` if NodeJS option --preserve-symlinks is set."
             },
             "extractLicenses": {
               "type": "boolean",

diff --git a/packages/angular_devkit/build_angular/src/browser/schema.json b/packages/angular_devkit/build_angular/src/browser/schema.json
@@ -248,8 +248,7 @@
     },
     "preserveSymlinks": {
       "type": "boolean",
-      "description": "Do not use the real path when resolving modules.",
-      "default": false
+      "description": "Do not use the real path when resolving modules. If unset then will default to `true` if NodeJS option --preserve-symlinks is set."
     },
     "extractLicenses": {
       "type": "boolean",

diff --git a/packages/angular_devkit/build_angular/src/karma/schema.json b/packages/angular_devkit/build_angular/src/karma/schema.json
@@ -126,8 +126,7 @@
     },
     "preserveSymlinks": {
       "type": "boolean",
-      "description": "Do not use the real path when resolving modules.",
-      "default": false
+      "description": "Do not use the real path when resolving modules. If unset then will default to `true` if NodeJS option --preserve-symlinks is set."
     },
     "browsers": {
       "type": "string",

diff --git a/packages/angular_devkit/build_angular/src/server/schema.json b/packages/angular_devkit/build_angular/src/server/schema.json
@@ -198,8 +198,7 @@
     },
     "preserveSymlinks": {
       "type": "boolean",
-      "description": "Do not use the real path when resolving modules.",
-      "default": false
+      "description": "Do not use the real path when resolving modules. If unset then will default to `true` if NodeJS option --preserve-symlinks is set."
     },
     "extractLicenses": {
       "type": "boolean",

diff --git a/packages/angular_devkit/build_angular/src/utils/normalize-builder-schema.ts b/packages/angular_devkit/build_angular/src/utils/normalize-builder-schema.ts
@@ -53,7 +53,7 @@ export function normalizeBrowserSchema(
     fileReplacements: normalizeFileReplacements(options.fileReplacements || [], syncHost, root),
     optimization: normalizeOptimization(options.optimization),
     sourceMap: normalizedSourceMapOptions,
-
+    preserveSymlinks: options.preserveSymlinks === undefined ? process.execArgv.includes('--preserve-symlinks') : options.preserveSymlinks,
     statsJson: options.statsJson || false,
     forkTypeChecker: options.forkTypeChecker || false,
     budgets: options.budgets || [],

diff --git a/packages/schematics/angular/utility/config.ts b/packages/schematics/angular/utility/config.ts
@@ -388,7 +388,8 @@ export interface CliConfig {
            */
           deleteOutputPath?: boolean;
           /**
-           * Do not use the real path when resolving modules.
+           * Do not use the real path when resolving modules. If unset then will default to `true` if NodeJS option --preserve-symlinks is
+           * set.
            */
           preserveSymlinks?: boolean;
           /**

diff --git a/tests/angular_devkit/core/json/schema/serializers/schema_benchmark.json b/tests/angular_devkit/core/json/schema/serializers/schema_benchmark.json
@@ -479,9 +479,8 @@
               "default": true
             },
             "preserveSymlinks": {
-              "description": "Do not use the real path when resolving modules.",
-              "type": "boolean",
-              "default": false
+              "description": "Do not use the real path when resolving modules. If unset then will default to `true` if NodeJS option --preserve-symlinks is set.",
+              "type": "boolean"
             },
             "showCircularDependencies": {
               "description": "Show circular dependency warnings on builds.",