Skip to content

Commit

Permalink
feat(@schematics/angular): use eventCoalescing option by default (sta…
Browse files Browse the repository at this point in the history
…ndalone bootstrap)

This commit enables eventCoalescing by default for standalone applications.
  • Loading branch information
Pawel Kozlowski authored and alan-agius4 committed Mar 29, 2024
1 parent fc7d796 commit 7258837
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 14 deletions.
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
import { ApplicationConfig } from '@angular/core';<% if (routing) { %>
import { ApplicationConfig, provideZoneChangeDetection } from '@angular/core';<% if (routing) { %>
import { provideRouter } from '@angular/router';

import { routes } from './app.routes';<% } %>

export const appConfig: ApplicationConfig = {
providers: [<% if (routing) { %>provideRouter(routes)<% } %>]
providers: [provideZoneChangeDetection({eventCoalescing: true})<% if (routing) { %>, provideRouter(routes)<% } %>]
};
2 changes: 1 addition & 1 deletion packages/schematics/angular/server/index_spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ describe('Server Schematic', () => {
it(`should add 'provideClientHydration' to the providers list`, async () => {
const tree = await schematicRunner.runSchematic('server', defaultOptions, appTree);
const contents = tree.readContent('/projects/bar/src/app/app.config.ts');
expect(contents).toContain(`providers: [provideClientHydration()]`);
expect(contents).toContain(`provideClientHydration()`);
});
});

Expand Down
12 changes: 7 additions & 5 deletions packages/schematics/angular/service-worker/index_spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -128,17 +128,19 @@ describe('Service Worker Schematic', () => {
const tree = await schematicRunner.runSchematic('service-worker', defaultOptions, appTree);
const content = tree.readContent('/projects/bar/src/app/app.config.ts');
expect(tags.oneLine`${content}`).toContain(tags.oneLine`
providers: [provideServiceWorker('ngsw-worker.js', {
enabled: !isDevMode(),
registrationStrategy: 'registerWhenStable:30000'
})]
provideServiceWorker('ngsw-worker.js', {
enabled: !isDevMode(),
registrationStrategy: 'registerWhenStable:30000'
})
`);
});

it(`should import 'isDevMode' from '@angular/core'`, async () => {
const tree = await schematicRunner.runSchematic('service-worker', defaultOptions, appTree);
const content = tree.readContent('/projects/bar/src/app/app.config.ts');
expect(content).toContain(`import { ApplicationConfig, isDevMode } from '@angular/core';`);
expect(content).toContain(
`import { ApplicationConfig, provideZoneChangeDetection, isDevMode } from '@angular/core';`,
);
});

it(`should import 'provideServiceWorker' from '@angular/service-worker'`, async () => {
Expand Down
12 changes: 6 additions & 6 deletions packages/schematics/angular/utility/standalone/rules_spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -93,12 +93,9 @@ describe('standalone utilities', () => {

const content = readFile('app/app.config.ts');

assertContains(
content,
`import { ApplicationConfig, importProvidersFrom } from '@angular/core';`,
);
assertContains(content, `importProvidersFrom`);
assertContains(content, `import { MyModule } from '@my/module';`);
assertContains(content, `providers: [importProvidersFrom(MyModule)]`);
assertContains(content, `importProvidersFrom(MyModule)`);
});

it('should add a root import to a standalone app whose app config does not have a providers array', async () => {
Expand Down Expand Up @@ -443,7 +440,10 @@ describe('standalone utilities', () => {
const content = readFile('app/app.config.ts');

assertContains(content, `import { provideModule } from '@my/module';`);
assertContains(content, `providers: [provideModule([])]`);
assertContains(
content,
`providers: [provideZoneChangeDetection({eventCoalescing:true}),provideModule([])]`,
);
});

it('should add a root provider to a standalone app when providers contain a trailing comma', async () => {
Expand Down

0 comments on commit 7258837

Please sign in to comment.