fix(@schematics/angular): update @angular peerDependencies for new …

…libraries
angular · Oct 19, 2018 · 8e963da · 8e963da
1 parent c45fd96
commit 8e963da
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/packages/schematics/angular/library/files/__projectRoot__/package.json b/packages/schematics/angular/library/files/__projectRoot__/package.json
@@ -2,7 +2,7 @@
   "name": "<%= dasherize(packageName) %>",
   "version": "0.0.1",
   "peerDependencies": {
-    "@angular/common": "^6.0.0-rc.0 || ^6.0.0",
-    "@angular/core": "^6.0.0-rc.0 || ^6.0.0"
+    "@angular/common": "^<%= angularLatestVersion %>",
+    "@angular/core": "^<%= angularLatestVersion %>"
   }
 }
diff --git a/packages/schematics/angular/library/index.ts b/packages/schematics/angular/library/index.ts
@@ -211,6 +211,7 @@ export default function (options: LibraryOptions): Rule {
         distRoot,
         relativePathToWorkspaceRoot,
         prefix,
+        angularLatestVersion: latestVersions.Angular.replace('~', '').replace('^', ''),
       }),
       // TODO: Moving inside `branchAndMerge` should work but is bugged right now.
       // The __projectRoot__ is being used meanwhile.

diff --git a/packages/schematics/angular/library/index_spec.ts b/packages/schematics/angular/library/index_spec.ts
@@ -63,6 +63,13 @@ describe('Library Schematic', () => {
     expect(fileContent).toMatch(/"name": "foo"/);
   });
 
+  it('should have the latest Angular major versions in package.json named "foo"', () => {
+    const tree = schematicRunner.runSchematic('library', defaultOptions, workspaceTree);
+    const fileContent = getJsonFileContent(tree, '/projects/foo/package.json');
+    const angularVersion = latestVersions.Angular.replace('~', '').replace('^', '');
+    expect(fileContent.peerDependencies['@angular/core']).toBe(`^${angularVersion}`);
+  });
+
   it('should create a tsconfig for library', () => {
     const tree = schematicRunner.runSchematic('library', defaultOptions, workspaceTree);
     const fileContent = getJsonFileContent(tree, '/projects/foo/tsconfig.lib.json');