Skip to content

Commit

Permalink
perf(@angular-devkit/build-angular): skip Angular linker in JIT mode …
Browse files Browse the repository at this point in the history
…with esbuild

When using the esbuild-based browser application builder in JIT mode, the Angular
linker will now be skipped. The runtime Angular compiler present in JIT applications
will automatically link any needed code.
  • Loading branch information
clydin authored and angular-robot[bot] committed Apr 6, 2023
1 parent e66698a commit c06b1bd
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -399,7 +399,7 @@ export function createCompilerPlugin(
// would need to be added to the key as well as a check for any change of content.
let contents = pluginOptions.sourceFileCache?.babelFileCache.get(args.path);
if (contents === undefined) {
contents = await javascriptTransformer.transformFile(args.path);
contents = await javascriptTransformer.transformFile(args.path, pluginOptions.jit);
pluginOptions.sourceFileCache?.babelFileCache.set(args.path, contents);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,15 @@ export class JavaScriptTransformer {
* Performs JavaScript transformations on a file from the filesystem.
* If no transformations are required, the data for the original file will be returned.
* @param filename The full path to the file.
* @param skipLinker If true, bypass all Angular linker processing; if false, attempt linking.
* @returns A promise that resolves to a UTF-8 encoded Uint8Array containing the result.
*/
transformFile(filename: string): Promise<Uint8Array> {
transformFile(filename: string, skipLinker?: boolean): Promise<Uint8Array> {
// Always send the request to a worker. Files are almost always from node modules which measn
// they may need linking. The data is also not yet available to perform most transformation checks.
return this.#workerPool.run({
filename,
skipLinker,
...this.#commonOptions,
});
}
Expand Down

0 comments on commit c06b1bd

Please sign in to comment.