Skip to content

Commit

Permalink
fix(@angular-devkit/build-angular): update esbuild builder complete log
Browse files Browse the repository at this point in the history
The complete log has been updated to match the RegExp in https://github.com/angular/angular-cli/blob/c045c99667cec8a5986302d59eef3d326e3a53d2/packages/schematics/angular/workspace/files/__dot__vscode/tasks.json.template#L18 as otherwise vscode debugged will not work correctly when using vscode launcher to launch the dev-server.

(cherry picked from commit b2a4f35)
  • Loading branch information
alan-agius4 committed Apr 25, 2023
1 parent b21a0e7 commit c272172
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Expand Up @@ -267,7 +267,7 @@ async function execute(
logBuildStats(context, metafile, initialFiles);

const buildTime = Number(process.hrtime.bigint() - startTime) / 10 ** 9;
context.logger.info(`Complete. [${buildTime.toFixed(3)} seconds]`);
context.logger.info(`Application bundle generation complete. [${buildTime.toFixed(3)} seconds]`);

return executionResult;
}
Expand Down
2 changes: 1 addition & 1 deletion tests/legacy-cli/e2e/tests/basic/rebuild.ts
Expand Up @@ -6,7 +6,7 @@ import { getGlobalVariable } from '../../utils/env';

export default async function () {
const esbuild = getGlobalVariable('argv')['esbuild'];
const validBundleRegEx = esbuild ? /Complete\./ : /Compiled successfully\./;
const validBundleRegEx = esbuild ? /complete\./ : /Compiled successfully\./;
const lazyBundleRegEx = esbuild ? /lazy\.module/ : /lazy_module_ts\.js/;

const port = await ngServe();
Expand Down
2 changes: 1 addition & 1 deletion tests/legacy-cli/e2e/utils/project.ts
Expand Up @@ -27,7 +27,7 @@ export async function ngServe(...args: string[]) {
const port = await findFreePort();

const esbuild = getGlobalVariable('argv')['esbuild'];
const validBundleRegEx = esbuild ? /Complete\./ : /Compiled successfully\./;
const validBundleRegEx = esbuild ? /complete\./ : /Compiled successfully\./;

await execAndWaitForOutputToMatch(
'ng',
Expand Down

0 comments on commit c272172

Please sign in to comment.