Address comments left on the PR

angular · Mar 13, 2023 · cba55bb · cba55bb
1 parent 682638c
commit cba55bb
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 9 deletions.
diff --git a/...chematics/angular/application/files/other-standalone-files/app.component.spec.ts.template b/...chematics/angular/application/files/other-standalone-files/app.component.spec.ts.template
@@ -4,12 +4,10 @@ import { AppComponent } from './app.component';
 
 describe('AppComponent', () => {
   beforeEach(async () => {
-    await TestBed.configureTestingModule({<% if (routing) { %>
+    await TestBed.configureTestingModule({
       imports: [
-        RouterTestingModule
-      ],<% } %>
-      declarations: [
-        AppComponent
+        AppComponent<% if (routing) { %>,
+        RouterTestingModule<% } %>
       ],
     }).compileComponents();
   });
@@ -20,7 +18,7 @@ describe('AppComponent', () => {
     expect(app).toBeTruthy();
   });
 
-  it(`should have as title '<%= name %>'`, () => {
+  it(`should have the '<%= name %>' title`, () => {
     const fixture = TestBed.createComponent(AppComponent);
     const app = fixture.componentInstance;
     expect(app.title).toEqual('<%= name %>');

diff --git a/...ages/schematics/angular/application/files/standalone-files/src/app/app.config.ts.template b/...ages/schematics/angular/application/files/standalone-files/src/app/app.config.ts.template
@@ -1,4 +1,4 @@
-import { ApplicationConfig } from '@angular/platform-browser';<% if (routing) { %>
+import { ApplicationConfig } from '@angular/core';<% if (routing) { %>
 import { provideRouter } from '@angular/router';<% } %>
 import { provideHttpClient } from '@angular/common/http';<% if (routing) { %>
 

diff --git a/packages/schematics/angular/application/files/standalone-files/src/index.html.template b/packages/schematics/angular/application/files/standalone-files/src/index.html.template
@@ -8,6 +8,6 @@
   <link rel="icon" type="image/x-icon" href="favicon.ico">
 </head>
 <body>
-  <<%= prefix %>-root></<%= prefix %>-root>
+  <<%= selector %>></<%= selector %>>
 </body>
 </html>
diff --git a/packages/schematics/angular/application/files/standalone-files/src/main.ts.template b/packages/schematics/angular/application/files/standalone-files/src/main.ts.template
@@ -3,5 +3,5 @@ import { appConfig } from './app/app.config';
 import { AppComponent } from './app/app.component';
 
 bootstrapApplication(AppComponent, appConfig).catch((err) =>
-  console.error(err)
+  console.error(err);
 );
diff --git a/packages/schematics/angular/application/index.ts b/packages/schematics/angular/application/index.ts
@@ -140,6 +140,7 @@ function getStandaloneAppRules(
         applyTemplates({
           utils: strings,
           ...options,
+          selector: appRootSelector,
           relativePathToWorkspaceRoot: relativePathToWorkspaceRoot(appDir),
           appName: options.name,
           folderName,