Skip to content

Commit

Permalink
test: replace mentions of build-webpack with build-angular
Browse files Browse the repository at this point in the history
  • Loading branch information
filipesilva authored and hansl committed Mar 29, 2018
1 parent 9a9bc00 commit cbd12d9
Show file tree
Hide file tree
Showing 76 changed files with 80 additions and 80 deletions.
4 changes: 2 additions & 2 deletions packages/@angular/cli/plugins/karma.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
throw new Error(
'In Angular CLI >6.0 the Karma plugin is now exported by "@angular-devkit/build-webpack" instead.\n'
+ 'Please replace "@angular/cli" with "@angular-devkit/build-webpack" in your "karma.conf.js" file.'
'In Angular CLI >6.0 the Karma plugin is now exported by "@angular-devkit/build-angular" instead.\n'
+ 'Please replace "@angular/cli" with "@angular-devkit/build-angular" in your "karma.conf.js" file.'
);
2 changes: 1 addition & 1 deletion tests/e2e/tests/basic/assets.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export default function () {
'./src/output-asset.txt': 'output-asset.txt',
'./node_modules/some-package/node_modules-asset.txt': 'node_modules-asset.txt',
}))
// TODO(architect): Review allowOutsideOutDir logic inside build-webpack.
// TODO(architect): Review allowOutsideOutDir logic inside build-angular.
// // Add invalid asset config in angular.json.
// .then(() => updateJsonFile('angular.json', configJson => {
// const app = configJson['apps'][0];
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/allow-js.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { updateTsConfig } from '../../utils/project';
import { appendToFile, writeFile } from '../../utils/fs';

export default async function() {
// TODO(architect): Delete this test. It is now in devkit/build-webpack.
// TODO(architect): Delete this test. It is now in devkit/build-angular.

await writeFile('projects/test-project/src/my-js-file.js', 'console.log(1); export const a = 2;');
await appendToFile('projects/test-project/src/main.ts', `
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/aot/aot-decorators.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {expectToFail} from '../../../utils/utils';
import {ngVersionMatches} from '../../../utils/version';

export default function() {
// TODO(architect): This behaviour seems to have changed in devkit/build-webpack. Figure out why.
// TODO(architect): This behaviour seems to have changed in devkit/build-angular. Figure out why.
return;

return ng('generate', 'component', 'test-component', '--module', 'app.module.ts')
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/aot/aot-i18n.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { SemVer } from 'semver';

// tslint:disable:max-line-length
export default function () {
// TODO(architect): Delete this test. It is now in devkit/build-webpack.
// TODO(architect): Delete this test. It is now in devkit/build-angular.

return Promise.resolve()
.then(() => createDir('projects/test-project/src/locale'))
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/base-href.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { expectFileToMatch } from '../../utils/fs';


export default function() {
// TODO(architect): Delete this test. It is now in devkit/build-webpack.
// TODO(architect): Delete this test. It is now in devkit/build-angular.

return ng('build', '--base-href', '/myUrl')
.then(() => expectFileToMatch('dist/test-project/index.html', /<base href="\/myUrl">/));
Expand Down
4 changes: 2 additions & 2 deletions tests/e2e/tests/build/build-app-shell.ts
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,15 @@ export default function () {
.then(() => updateJsonFile('angular.json', workspaceJson => {
const appArchitect = workspaceJson.projects['test-project'].architect;
appArchitect['server'] = {
builder: '@angular-devkit/build-webpack:server',
builder: '@angular-devkit/build-angular:server',
options: {
outputPath: 'dist/test-project-server',
main: 'projects/test-project/src/main.server.ts',
tsConfig: 'projects/test-project/tsconfig.server.json'
}
};
appArchitect['app-shell'] = {
builder: '@angular-devkit/build-webpack:app-shell',
builder: '@angular-devkit/build-angular:app-shell',
options: {
browserTarget: 'test-project:build:production',
serverTarget: 'test-project:server',
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/build-errors.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const extraErrors = [
];

export default function () {
// TODO(architect): Delete this test. It is now in devkit/build-webpack.
// TODO(architect): Delete this test. It is now in devkit/build-angular.

if (process.platform.startsWith('win')) {
return Promise.resolve();
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/build-optimizer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { expectToFail } from '../../utils/utils';


export default function () {
// TODO(architect): Delete this test. It is now in devkit/build-webpack.
// TODO(architect): Delete this test. It is now in devkit/build-angular.

return ng('build', '--aot', '--build-optimizer')
.then(() => expectToFail(() => expectFileToMatch('dist/test-project/main.js', /\.decorators =/)))
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/chunk-hash.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ function validateHashes(
}

export default function() {
// TODO(architect): Delete this test. It is now in devkit/build-webpack.
// TODO(architect): Delete this test. It is now in devkit/build-angular.
return;

let oldHashes: Map<string, string>;
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/delete-output-path.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {deleteFile, expectFileToExist} from '../../utils/fs';
import {getGlobalVariable} from '../../utils/env';

export default function() {
// TODO(architect): Delete this test. It is now in devkit/build-webpack.
// TODO(architect): Delete this test. It is now in devkit/build-angular.

// Skip this in ejected tests.
if (getGlobalVariable('argv').eject) {
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/extract-licenses.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {expectToFail} from '../../utils/utils';
import {ng} from '../../utils/process';

export default function() {
// TODO(architect): Delete this test. It is now in devkit/build-webpack.
// TODO(architect): Delete this test. It is now in devkit/build-angular.

return ng('build', '--prod', '--extract-licenses=false')
.then(() => expectFileToExist(join(process.cwd(), 'dist')))
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/json.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {getGlobalVariable} from '../../utils/env';


export default function() {
// TODO(architect): Delete this test. It is now in devkit/build-webpack.
// TODO(architect): Delete this test. It is now in devkit/build-angular.

// Skip this in ejected tests.
if (getGlobalVariable('argv').eject) {
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/no-entry-module.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { ng } from '../../utils/process';


export default async function() {
// TODO(architect): Delete this test. It is now in devkit/build-webpack.
// TODO(architect): Delete this test. It is now in devkit/build-angular.

const mainTs = await readFile('projects/test-project/src/main.ts');

Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/output-dir.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {expectToFail} from '../../utils/utils';


export default function() {
// TODO(architect): Delete this test. It is now in devkit/build-webpack.
// TODO(architect): Delete this test. It is now in devkit/build-angular.

// Skip this in ejected tests.
if (getGlobalVariable('argv').eject) {
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/platform-server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ export default function () {
.then(() => updateJsonFile('angular.json', workspaceJson => {
const appArchitect = workspaceJson.projects['test-project'].architect;
appArchitect['server'] = {
builder: '@angular-devkit/build-webpack:server',
builder: '@angular-devkit/build-angular:server',
options: {
outputPath: 'dist/test-project-server',
main: 'projects/test-project/src/main.server.ts',
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/poll.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {expectToFail, wait} from '../../utils/utils';
const webpackGoodRegEx = /: Compiled successfully./;

export default function() {
// TODO(architect): This test is behaving oddly both here and in devkit/build-webpack.
// TODO(architect): This test is behaving oddly both here and in devkit/build-angular.
// It seems to be because of file watchers.
return;

Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/polyfills.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { ng } from '../../utils/process';
import { oneLineTrim } from 'common-tags';

export default function () {
// TODO(architect): Delete this test. It is now in devkit/build-webpack.
// TODO(architect): Delete this test. It is now in devkit/build-angular.

return Promise.resolve()
.then(() => ng('build'))
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/prod-build.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {getGlobalVariable} from '../../utils/env';


export default function() {
// TODO(architect): Delete this test. It is now in devkit/build-webpack.
// TODO(architect): Delete this test. It is now in devkit/build-angular.

// Skip this in ejected tests.
const ejected = getGlobalVariable('argv').eject;
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/rebuild-css-change.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {getGlobalVariable} from '../../utils/env';
const webpackGoodRegEx = /: Compiled successfully./;

export default function() {
// TODO(architect): Delete this test. It is now in devkit/build-webpack.
// TODO(architect): Delete this test. It is now in devkit/build-angular.

if (process.platform.startsWith('win')) {
return Promise.resolve();
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/rebuild-deps-type-check.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const errorRe = /ERROR in/;


export default function() {
// TODO(architect): Delete this test. It is now in devkit/build-webpack.
// TODO(architect): Delete this test. It is now in devkit/build-angular.

if (process.platform.startsWith('win')) {
return Promise.resolve();
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/rebuild-error.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const extraErrors = [
];

export default function () {
// TODO(architect): This test is behaving oddly both here and in devkit/build-webpack.
// TODO(architect): This test is behaving oddly both here and in devkit/build-angular.
// It seems to be because of file watchers.
return;

Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/rebuild-ngfactories.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { getGlobalVariable } from '../../utils/env';
const validBundleRegEx = /: Compiled successfully./;

export default function () {
// TODO(architect): This test is behaving oddly both here and in devkit/build-webpack.
// TODO(architect): This test is behaving oddly both here and in devkit/build-angular.
// It seems to be because of file watchers.
return;

Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/rebuild-types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import {getGlobalVariable} from '../../utils/env';
const successRe = /: Compiled successfully/;

export default async function() {
// TODO(architect): Delete this test. It is now in devkit/build-webpack.
// TODO(architect): Delete this test. It is now in devkit/build-angular.

if (process.platform.startsWith('win')) {
return;
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/script-target.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { getGlobalVariable } from '../../utils/env';


export default function () {
// TODO(architect): Delete this test. It is now in devkit/build-webpack.
// TODO(architect): Delete this test. It is now in devkit/build-angular.

// Skip this test in Angular 2, it had different bundles.
if (getGlobalVariable('argv').ng2) {
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/sourcemap.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {expectToFail} from '../../utils/utils';


export default function() {
// TODO(architect): Delete this test. It is now in devkit/build-webpack.
// TODO(architect): Delete this test. It is now in devkit/build-angular.

return ng('build', '--source-map')
.then(() => expectFileToExist('dist/test-project/main.js.map'))
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/styles/empty-style-urls.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { ng } from '../../../utils/process';


export default function () {
// TODO(architect): Delete this test. It is now in devkit/build-webpack.
// TODO(architect): Delete this test. It is now in devkit/build-angular.

return Promise.resolve()
// Write assets.
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/styles/extract-css.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { expectToFail } from '../../../utils/utils';
import { oneLineTrim } from 'common-tags';

export default function () {
// TODO(architect): Delete this test. It is now in devkit/build-webpack.
// TODO(architect): Delete this test. It is now in devkit/build-angular.

return Promise.resolve()
.then(() => writeMultipleFiles({
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/styles/imports.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { updateJsonFile } from '../../../utils/project';
import { getGlobalVariable } from '../../../utils/env';

export default function () {
// TODO(architect): Delete this test. It is now in devkit/build-webpack.
// TODO(architect): Delete this test. It is now in devkit/build-angular.

// Disable parts of it in webpack tests.
const ejected = getGlobalVariable('argv').eject;
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/styles/inline-urls.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ const imgSvg = `
`;

export default function () {
// TODO(architect): Delete this test. It is now in devkit/build-webpack.
// TODO(architect): Delete this test. It is now in devkit/build-angular.

return Promise.resolve()
.then(() => silentNpm('install', 'font-awesome@4.7.0'))
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/styles/less.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { stripIndents } from 'common-tags';
import { updateJsonFile } from '../../../utils/project';

export default function () {
// TODO(architect): Delete this test. It is now in devkit/build-webpack.
// TODO(architect): Delete this test. It is now in devkit/build-angular.

return writeMultipleFiles({
'projects/test-project/src/styles.less': stripIndents`
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/styles/material-import.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { stripIndents } from 'common-tags';
import { updateJsonFile } from '../../../utils/project';

export default function () {
// TODO(architect): Delete this test. It is now in devkit/build-webpack.
// TODO(architect): Delete this test. It is now in devkit/build-angular.

const extensions = ['css', 'scss', 'less', 'styl'];
let promise: Promise<any> = Promise.resolve()
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/styles/postcss.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { ng } from '../../../utils/process';
import { stripIndents } from 'common-tags';

export default function () {
// TODO(architect): Delete this test. It is now in devkit/build-webpack.
// TODO(architect): Delete this test. It is now in devkit/build-angular.

return writeFile('projects/test-project/src/styles.css', stripIndents`
/* normal-comment */
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/styles/scss.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { stripIndents } from 'common-tags';
import { updateJsonFile } from '../../../utils/project';

export default function () {
// TODO(architect): Delete this test. It is now in devkit/build-webpack.
// TODO(architect): Delete this test. It is now in devkit/build-angular.

return writeMultipleFiles({
'projects/test-project/src/styles.scss': stripIndents`
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/styles/stylus.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { stripIndents } from 'common-tags';
import { updateJsonFile } from '../../../utils/project';

export default function () {
// TODO(architect): Delete this test. It is now in devkit/build-webpack.
// TODO(architect): Delete this test. It is now in devkit/build-angular.

return writeMultipleFiles({
'projects/test-project/src/styles.styl': stripIndents`
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/subresource-integrity.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { expectToFail } from '../../utils/utils';
const integrityRe = /integrity="\w+-[A-Za-z0-9\/\+=]+"/;

export default async function() {
// TODO(architect): Delete this test. It is now in devkit/build-webpack.
// TODO(architect): Delete this test. It is now in devkit/build-angular.

// WEBPACK4_DISABLED - disabled pending a webpack 4 version
return;
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/ts-paths.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import {stripIndents} from 'common-tags';


export default function() {
// TODO(architect): Delete this test. It is now in devkit/build-webpack.
// TODO(architect): Delete this test. It is now in devkit/build-angular.

return updateTsConfig(json => {
json['compilerOptions']['baseUrl'] = './src';
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/vendor-chunk.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {expectToFail} from '../../utils/utils';


export default function() {
// TODO(architect): Delete this test. It is now in devkit/build-webpack.
// TODO(architect): Delete this test. It is now in devkit/build-angular.

return ng('build')
.then(() => expectFileToExist('dist/test-project/vendor.js'))
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/build/watch.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { expectToFail } from '../../utils/utils';
const webpackGoodRegEx = /: Compiled successfully./;

export default function () {
// TODO(architect): This test is behaving oddly both here and in devkit/build-webpack.
// TODO(architect): This test is behaving oddly both here and in devkit/build-angular.
// It seems to be because of file watchers.
return;

Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/commands/build/build-outdir.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import {updateJsonFile} from '../../../utils/project';
import {expectToFail} from '../../../utils/utils';

export default function() {
// TODO(architect): This isn't working correctly in devkit/build-webpack, due to module resolution.
// TODO(architect): This isn't working correctly in devkit/build-angular, due to module resolution.
return;

return Promise.resolve()
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/commands/serve/serve-path.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { killAllProcesses } from '../../../utils/process';
import { ngServe } from '../../../utils/project';

export default function () {
// TODO(architect): Delete this test. It is now in devkit/build-webpack.
// TODO(architect): Delete this test. It is now in devkit/build-angular.

return Promise.resolve()
.then(() => ngServe('--serve-path', 'test/'))
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/i18n/build-locale.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { getGlobalVariable } from '../../utils/env';


export default function () {
// TODO(architect): Delete this test. It is now in devkit/build-webpack.
// TODO(architect): Delete this test. It is now in devkit/build-angular.

// Skip this test in Angular 2/4.
if (getGlobalVariable('argv').ng2 || getGlobalVariable('argv').ng4) {
Expand Down
2 changes: 1 addition & 1 deletion tests/e2e/tests/i18n/extract-default.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {


export default function() {
// TODO(architect): Delete this test. It is now in devkit/build-webpack.
// TODO(architect): Delete this test. It is now in devkit/build-angular.

return ng('generate', 'component', 'i18n-test')
.then(() => writeFile(
Expand Down

0 comments on commit cbd12d9

Please sign in to comment.