test: update E2E tests to support protractor with native promises

angular · Oct 5, 2020 · d53da2d · d53da2d
1 parent 49be173
commit d53da2d
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 29 deletions.
diff --git a/tests/legacy-cli/e2e/tests/build/lazy-load-syntax.ts b/tests/legacy-cli/e2e/tests/build/lazy-load-syntax.ts
@@ -56,9 +56,9 @@ export default async function () {
     import { browser, logging, element, by } from 'protractor';
 
     describe('workspace-project App', () => {
-      it('should display lazy route', () => {
-        browser.get(browser.baseUrl + '/lazy');
-        expect(element(by.css('app-lazy-comp p')).getText()).toEqual('lazy-comp works!');
+      it('should display lazy route', async () => {
+        await browser.get(browser.baseUrl + '/lazy');
+        expect(await element(by.css('app-lazy-comp p')).getText()).toEqual('lazy-comp works!');
       });
 
       afterEach(async () => {

diff --git a/tests/legacy-cli/e2e/tests/build/rollup.ts b/tests/legacy-cli/e2e/tests/build/rollup.ts
@@ -35,9 +35,9 @@ export default async function () {
     import { browser, logging, element, by } from 'protractor';
 
     describe('workspace-project App', () => {
-      it('should display lazy route', () => {
-        browser.get(browser.baseUrl + '/lazy');
-        expect(element(by.css('app-lazy p')).getText()).toEqual('lazy works!');
+      it('should display lazy route', async () => {
+        await browser.get(browser.baseUrl + '/lazy');
+        expect(await element(by.css('app-lazy p')).getText()).toEqual('lazy works!');
       });
 
       afterEach(async () => {

diff --git a/tests/legacy-cli/e2e/tests/generate/library/library-consumption.ts b/tests/legacy-cli/e2e/tests/generate/library/library-consumption.ts
@@ -52,9 +52,9 @@ export default async function () {
         page = new AppPage();
       });
 
-      it('should display text from library component', () => {
-        page.navigateTo();
-        expect(element(by.css('lib-my-lib p')).getText()).toEqual('my-lib works!');
+      it('should display text from library component', async () => {
+        await page.navigateTo();
+        expect(await element(by.css('lib-my-lib p')).getText()).toEqual('my-lib works!');
       });
 
       afterEach(async () => {

diff --git a/tests/legacy-cli/e2e/tests/i18n/legacy.ts b/tests/legacy-cli/e2e/tests/i18n/legacy.ts
@@ -125,7 +125,7 @@ export async function setupI18nConfig(useLocalize = true, format: keyof typeof f
       import { browser, logging, element, by } from 'protractor';
 
       describe('workspace-project App', () => {
-        const getParagraph = (name: string) => element(by.css('app-root p#' + name)).getText();
+        const getParagraph = async (name: string) => element(by.css('app-root p#' + name)).getText();
         beforeEach(() => browser.get(browser.baseUrl));
         afterEach(async () => {
           // Assert that there are no errors emitted from the browser
@@ -135,17 +135,17 @@ export async function setupI18nConfig(useLocalize = true, format: keyof typeof f
           } as logging.Entry));
         });
 
-        it('should display welcome message', () =>
-          expect(getParagraph('hello')).toEqual('${translation.hello}'));
+        it('should display welcome message', async () =>
+          expect(await getParagraph('hello')).toEqual('${translation.hello}'));
 
-        it('should display locale', () =>
-          expect(getParagraph('locale')).toEqual('${lang}'));
+        it('should display locale', async () =>
+          expect(await getParagraph('locale')).toEqual('${lang}'));
 
-        it('should display localized date', () =>
-          expect(getParagraph('date')).toEqual('${translation.date}'));
+        it('should display localized date', async () =>
+          expect(await getParagraph('date')).toEqual('${translation.date}'));
 
-        it('should display pluralized message', () =>
-          expect(getParagraph('plural')).toEqual('${translation.plural}'));
+        it('should display pluralized message', async () =>
+          expect(await getParagraph('plural')).toEqual('${translation.plural}'));
       });
     `);
   }

diff --git a/tests/legacy-cli/e2e/tests/misc/third-party-decorators.ts b/tests/legacy-cli/e2e/tests/misc/third-party-decorators.ts
@@ -16,11 +16,11 @@ export default function () {
       './e2e/src/app.po.ts': `
         import { browser, by, element } from 'protractor';
         export class AppPage {
-          navigateTo() {    return browser.get('/');  }
+          async navigateTo() {    return browser.get('/');  }
           getIncrementButton() { return element(by.buttonText('Increment')); }
           getDecrementButton() { return element(by.buttonText('Decrement')); }
           getResetButton() { return element(by.buttonText('Reset Counter')); }
-          getCounter() { return element(by.xpath('/html/body/app-root/div/span')).getText(); }
+          async getCounter() { return element(by.xpath('/html/body/app-root/div/span')).getText(); }
         }
       `,
       './e2e/src/app.e2e-spec.ts': `
@@ -33,15 +33,15 @@ export default function () {
             page = new AppPage();
           });
 
-          it('should operate counter', () => {
-            page.navigateTo();
-            page.getIncrementButton().click();
-            page.getIncrementButton().click();
-            expect(page.getCounter()).toEqual('2');
-            page.getDecrementButton().click();
-            expect(page.getCounter()).toEqual('1');
-            page.getResetButton().click();
-            expect(page.getCounter()).toEqual('0');
+          it('should operate counter', async () => {
+            await page.navigateTo();
+            await page.getIncrementButton().click();
+            await page.getIncrementButton().click();
+            expect(await page.getCounter()).toEqual('2');
+            await page.getDecrementButton().click();
+            expect(await page.getCounter()).toEqual('1');
+            await page.getResetButton().click();
+            expect(await page.getCounter()).toEqual('0');
           });
         });
       `,