Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rxjs-compat NOT automatically installed #10631

Closed
jtsom opened this issue May 4, 2018 · 16 comments
Closed

rxjs-compat NOT automatically installed #10631

jtsom opened this issue May 4, 2018 · 16 comments
Labels
freq2: medium P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent type: bug/fix workaround1: obvious
Milestone

Comments

@jtsom
Copy link
Contributor

jtsom commented May 4, 2018

Per the paragraph on the announcement blog page:

For example, the command ng update @angular/core will update all of the Angular framework packages as well as RxJS and TypeScript, and will run any schematics available on these packages to keep you up to date. As part of this one command, we’ll automatically install rxjs-compat into your application to make the adoption of RxJS v6 smoother.

However, after running the ng upgrade commands, rxjs-compat was NOT automatically installed. When I ran my app, there were several errors related to rxjs

node_modules/rxjs/Observable.d.ts(1,15): error TS2307: Cannot find module 'rxjs-compat/Observable'.
src/app/students/students.component.ts(2,10): error TS2305: Module '"/Users/john/Dev/DotNet/TimeTracker/node_modules/rxjs/Observable"' has no exported member 'Observable'.
src/app/students/students.service.ts(3,10): error TS2305: Module '"/Users/john/Dev/DotNet/TimeTracker/node_modules/rxjs/Observable"' has no exported member 'Observable'.

Versions

Angular CLI: 6.0.0
Node: 10.0.0
OS: darwin x64
Angular: 6.0.0
... animations, cli, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.6.0
@angular-devkit/build-angular     0.6.0
@angular-devkit/build-optimizer   0.6.0
@angular-devkit/core              0.6.0
@angular-devkit/schematics        0.6.0
@ngtools/webpack                  6.0.0
@schematics/angular               0.6.0
@schematics/update                0.6.0
rxjs                              6.1.0
typescript                        2.7.2
webpack                           4.6.0

Repro steps

  • Update an existing app, per directions on update.angular.io

Observed behavior

rxjs-compat was not added to package.json automatically

Desired behavior

Per the docs, rxjs-compat should have been installed.

Mention any other details that might be useful (optional)

@filipesilva filipesilva added type: bug/fix P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful workaround1: obvious comp: cli/update freq2: medium labels May 4, 2018
@shkarab
Copy link

shkarab commented May 4, 2018

same issues here

@CanKer
Copy link

CanKer commented May 4, 2018

same here

@AlexanderFalconi
Copy link

Same here.

@FreakyMithril
Copy link

same

@ivancas84
Copy link

ivancas84 commented May 6, 2018

same issue.

This package allowed me to keep working:

npm install rxjs-compat@6.0.0-tactical-rc.1

@MrJmpl3
Copy link

MrJmpl3 commented May 7, 2018

See .. https://update.angular.io/ ..

In the last parts:

"Once you and all of your dependencies have updated to RxJS 6, remove rxjs-compat."

@ElisePatrikainen
Copy link

Same - I tried to run as well ng update rxjs, but it did not add rxjs-compat to the package.json, neither added it to the npm list.

@sachinpachori
Copy link

Same here.

@Group10Chennai
Copy link

I too have the same issue but resolved by

npm install rxjs-compat@6.0.0-tactical-rc.1

@sreeksp
Copy link

sreeksp commented Jul 7, 2018

@here removing rxjs-compat after the migration still throw the same error

@alexeagle
Copy link
Contributor

As time passes, fewer users are still updating to Angular 6, so lowering the priority. Sorry this wasn't fixed already.

@alexeagle alexeagle added P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent and removed P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful labels Jul 28, 2018
@Saif-Ihsan
Copy link

same issue here :(

@buka102
Copy link

buka102 commented Dec 20, 2018

same here

@yogeshpatil143
Copy link

npm i rxjs-compat

Add these on o your root folder

@ngbot ngbot bot added this to the needsTriage milestone Jan 24, 2019
@clydin
Copy link
Member

clydin commented May 27, 2020

rxjs-compat should not longer be needed. However if this issue is still occurring for anyone, the rxjs package itself contains the necessary migrations to install the rxjs-compat package. Please open an issue with rxjs if the update migrations are not being properly executed when updating from a pre-6.0 version of rxjs to a new version via the ng update command.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
freq2: medium P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent type: bug/fix workaround1: obvious
Projects
None yet
Development

No branches or pull requests