Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is the buildWebpackConfig() method private in the KarmaBuilder class? #12447

Closed
epaitz opened this issue Oct 3, 2018 · 1 comment · Fixed by #12449
Closed

Why is the buildWebpackConfig() method private in the KarmaBuilder class? #12447

epaitz opened this issue Oct 3, 2018 · 1 comment · Fixed by #12449
Milestone

Comments

@epaitz
Copy link

epaitz commented Oct 3, 2018

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an x)

- [ ] new
- [ ] build
- [ ] serve
- [X] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

Angular 6 CLI (6.1.0)

Why is the buildWebpackConfig() method marked as private in the KarmaBuilder found in (angular-cli/packages/angular_devkit/build_angular/src/karma/index.ts)? Is this by design or a mistake? I am trying to create a custom webpack builder, similar to https://github.com/meltedspark/angular-builders/tree/master/packages/custom-webpack. This project extends the BrowserBuilder and overrides its buildWebpackConfig() method. Is the same suppose to be possible for the KarmaBuilder class too? … or is there another way we should be extending the KarmaBuilder?

Thanks,

-eric

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants