Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress indication for schematics #12479

Open
devversion opened this issue Oct 4, 2018 · 3 comments
Open

Progress indication for schematics #12479

devversion opened this issue Oct 4, 2018 · 3 comments
Labels
area: angular/cli area: devkit/schematics feature: votes required Feature request which is currently still in the voting phase feature Issue that requests a new feature ng update DX
Milestone

Comments

@devversion
Copy link
Member

devversion commented Oct 4, 2018

Since the TSLintFixTask can take a lot of time (e.g. if used to apply source code transformations for ng-update), it would be nice to have a progress indicator that shows that "something" actually runs.

For example: if someone runs ng update @angular/material@next, it's not clear for a period of time that the fix task actually "runs". See: angular/components#12774.

An option that can be specified when configuring the TSlintFixTask would be nice to have. The option would then show a simple progress indicator while TSLint runs.


Ideally there would be a way for a schematic to:

  • Have an progress-spinner with a name of the schematic currently running
  • Report a status (similar to how Bazel repository_ctx can report statuses)

Nowadays a lot of schematics need to run as part of an ng update and it would be helpful to know what schematic currently runs / what it currently does (if known)

cc. @jelbourn

@ngbot ngbot bot added this to the Backlog milestone Oct 4, 2018
@devversion devversion changed the title Progress indicator for TSLint fix task Progress indication for schematics May 10, 2019
@Splaktar
Copy link
Member

Splaktar commented May 10, 2019

Note that while having the ability to indicate a % complete would be nice in some cases, in the general case, it's most important to just be able to indicate that schematic X is currently running.

With Angular version 8, some of my schematics for core, CLI, and material/cdk were taking 10+ minutes to complete, but it seemed like they were hung/unresponsive. This is bad DX.

@devversion
Copy link
Member Author

Totally agree. Thanks for adding that!

@alan-agius4
Copy link
Collaborator

Also tracked internally in http://b/188066584.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: angular/cli area: devkit/schematics feature: votes required Feature request which is currently still in the voting phase feature Issue that requests a new feature ng update DX
Projects
None yet
Development

No branches or pull requests

5 participants
@kyliau @Splaktar @devversion @alan-agius4 and others