New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inlineStyle and inlineTemplate should have precedence when used with minimal #17528
Comments
Hi, The mentioned PR aligned components generated after the initial app scaffolding to always be inlined, as minimal always generated the app component with inline templates and styles. Possible we can remove the “feature” to auto inline styles and templates when using ‘minimal`. That said, it’s important to point that minimal projects are considered to be “throw away” and only used for quick testing and prototyping. //cc @clydin, @filipesilva thoughts? |
Hi @alan-agius4, it didn't always do that. I have an older project from the version 7 days where inline styles & templates were not forced with minimal. I could be mistaken, though. I have reviewed several issues where you have brought up those points about minimal. The issues appear to be around linting and testing. Are there any other notable issues that could surface when using minimal? |
Yes, in most cases the effected areas are linting and testing, but there might also be broken journeys such as incorrect/extra files being generated when using other schematics such as generating a library. |
@alan-agius4 Thanks for clarifying. I'll limit my time with these project types. |
…al application This change allows `inlineTemplate=false` and/or `inlineStyle=false` to be used with the `minimal` option when creating an application either by `ng new` or `ng generate application`. Closes angular#17528
…al application This change allows `inlineTemplate=false` and/or `inlineStyle=false` to be used with the `minimal` option when creating an application either by `ng new` or `ng generate application`. Closes #17528
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
🚀 Feature request
Command (mark with an
x
)Description
PR #16988 has changed project generation in a way that prevents external styles and templates from being generated when using the
minimal
flag withng new
.Describe the solution you'd like
If you prefer this behavior by default, that is fine, but can you please make it so that when
inlineStyle=true
andinlineTemplate=true
withminimal=true
, it will actually generate the external files? Right now, those settings are ignored when used with minimal, and I don't believe they should be.Describe alternatives you've considered
I just regenerate the app component once the project has spun up (after removing inlineTemplate and inlineStyle from angular.json). That sets everything up the way I want, but it's still an extra step I'd like to avoid.
The text was updated successfully, but these errors were encountered: