Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in child compilers not reported, process exits without info #17565

Closed
2 of 15 tasks
nadavsinai opened this issue Apr 28, 2020 · 1 comment 路 Fixed by #18097
Closed
2 of 15 tasks

Errors in child compilers not reported, process exits without info #17565

nadavsinai opened this issue Apr 28, 2020 · 1 comment 路 Fixed by #18097

Comments

@nadavsinai
Copy link

nadavsinai commented Apr 28, 2020

馃悶 Bug report

Command (mark with an x)

  • new
  • build
  • serve
  • test
  • e2e
  • generate
  • add
  • update
  • lint
  • xi18n
  • run
  • config
  • help
  • version
  • doc

Is this a regression?

Yes, the previous version in which this bug was not present was: ....

no

Description

If a compilation includes child compilations as is the case when using worker-loader for example (or many other webpack loaders/plugins) the build process can fail and exit without providing any info but the exit code being 1.

馃敩 Minimal Reproduction

clone this, run ng build, no errors will be shown except of non-0 exit code or "failed to compile" in serve mode.
anything with a child compiler emits errors into it's own errors object.
you code in createBrowserLoggingCallback
which delegates to (stats.hasErrors() does not take into account the possibility of errors in child compilers.

馃敟 Exception or Error




the problem is the the error is not shown ;-)

馃實 Your Environment





Angular CLI: 8.3.23
Node: 12.16.2
OS: win32 x64
Angular: 8.2.14
... animations, common, compiler, compiler-cli, core, elements
... forms, language-service, platform-browser
... platform-browser-dynamic, platform-server, router

Package                            Version
------------------------------------------------------------
@angular-devkit/architect          0.803.23
@angular-devkit/build-angular      0.803.23
@angular-devkit/build-ng-packagr   0.803.26
@angular-devkit/build-optimizer    0.803.23
@angular-devkit/core               8.3.23
@angular-devkit/schematics         8.3.23
@angular/cdk                       8.2.3
@angular/cli                       8.3.23
@angular/flex-layout               8.0.0-beta.27
@schematics/angular                8.3.23
@schematics/update                 0.803.23
ng-packagr                         5.7.1
rxjs                               6.5.5
typescript                         3.5.3
webpack                            4.29.6


@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants