New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "ci: disable lint check in the update test" #18944
Conversation
The relevant blocking PR was merged, however it was reverted in angular/angular#39082 because it is not compatible with TS 3.9 which is still used in google3. I'm looking for a solution that will be compatible with both versions and we can re-enable this test once that lands. |
I have a fix in angular/angular#39102, where using |
e260226
to
006b6b5
Compare
The fix was merged and doesn't appear to have been rolled back yet, so I think it's safe to merge this PR and re-enable the lint check. |
Actually, CI is still failing for this PR itself, because the fix on |
This reverts commit 4271129. Re-enables lint check now that v11.0.0-next.4 has released.
@alan-agius4 pointed out that e2e tests load FW from NPM, so we only need FW to release the migration fix, not the CLI. This should be unblocked now. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Re-enabling the lint check to merge once
11.0.0-next.4
is released.I'll leave this PR in the blocked state until the version is released and angular/angular#39070 is merged. Once those have both happened, it should be safe to merge this as well.