Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(@schematics/angular): generate E2E tests with native promise support #18951

Merged
merged 3 commits into from Oct 5, 2020

Conversation

clydin
Copy link
Member

@clydin clydin commented Oct 2, 2020

This change adjusts the E2E schematic to generate a protractor configuration with the selenium promise manager disabled. It also adjusts the generated test files to use native promises and async/await to control test execution.

…port

This change adjusts the E2E schematic to generate a protractor configuration with the selenium promise manager disabled.  It also adjusts the generated test files to use native promises and async/await to control test execution.
@clydin clydin added the target: major This PR is targeted for the next major release label Oct 2, 2020
@kyliau kyliau added the action: merge The PR is ready for merge by the caretaker label Oct 5, 2020
@clydin clydin merged commit d53da2d into angular:master Oct 5, 2020
@clydin clydin deleted the protractor-promise-manager branch October 5, 2020 23:06
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants