Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(@schematics/angular): add prompt and analytics to strict mode #18983

Merged
merged 4 commits into from Oct 7, 2020
Merged

feat(@schematics/angular): add prompt and analytics to strict mode #18983

merged 4 commits into from Oct 7, 2020

Conversation

alan-agius4
Copy link
Collaborator

See each commit.

@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Oct 6, 2020
@alan-agius4 alan-agius4 changed the title feat(@schematics/angular): add prompt to strict mode feat(@schematics/angular): add prompt and analytics to strict mode Oct 6, 2020
@alan-agius4 alan-agius4 marked this pull request as ready for review October 6, 2020 10:49
kyliau
kyliau reviewed Oct 6, 2020
View reviewed changes
docs/design/analytics.md Show resolved Hide resolved
packages/schematics/angular/ng-new/schema.json Outdated Show resolved Hide resolved
aikithoughts
aikithoughts approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@aikithoughts aikithoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few edits for clarity and style standards. Otherwise, LGTM!

Reviewed-for: required-docs-approvers

packages/schematics/angular/ng-new/schema.json Outdated Show resolved Hide resolved
packages/schematics/angular/workspace/schema.json Outdated Show resolved Hide resolved
kyliau
kyliau approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@kyliau kyliau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think adding the "why" is really important to encourage users to turn on this flag. Well done and thank you!

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Oct 7, 2020
@clydin clydin merged commit 811966a into angular:master Oct 7, 2020
@alan-agius4 alan-agius4 deleted the strict-prompt branch October 7, 2020 17:23
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 7, 2020
@alan-agius4 alan-agius4 restored the strict-prompt branch November 20, 2020 11:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kyliau kyliau kyliau approved these changes

@clydin clydin clydin approved these changes

@aikithoughts aikithoughts aikithoughts approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@alan-agius4 @kyliau @clydin @aikithoughts @googlebot