Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(@schematics/angular): add prompt and analytics to strict mode #18983

Merged
merged 4 commits into from
Oct 7, 2020
Merged

feat(@schematics/angular): add prompt and analytics to strict mode #18983

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
71e168e
refactor(@angular-devkit/core): remove unused `NgBuildBuildEventLog` …
alan-agius4 Oct 6, 2020
f36826c
feat(@schematics/angular): add user-analytics to strict mode option
alan-agius4 Oct 6, 2020
d9060c5
feat(@schematics/angular): add prompt to strict mode
alan-agius4 Oct 6, 2020
7f9d0c1
docs: improve strict option description
alan-agius4 Oct 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/design/analytics.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ Note: There's a limit of 20 custom dimensions.
| 4 | `Node Version` | `number` |
| 5 | `Flag: --style` | `string` |
| 6 | `--collection` | `string` |
| 7 | `--buildEventLog` | `boolean` |
| 7 | `Flag: --strict` | `boolean` |
alan-agius4 marked this conversation as resolved.
Show resolved Hide resolved
| 8 | `Ivy Enabled` | `boolean` |
| 9 | `Flag: --inlineStyle` | `boolean` |
| 10 | `Flag: --inlineTemplate` | `boolean` |
Expand Down
1 change: 0 additions & 1 deletion etc/api/angular_devkit/core/src/_golden-api.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,6 @@ export declare enum NgCliAnalyticsDimensions {
RamInGigabytes = 3,
NodeVersion = 4,
NgAddCollection = 6,
NgBuildBuildEventLog = 7,
NgIvyEnabled = 8,
BuildErrors = 20
}
Expand Down
3 changes: 0 additions & 3 deletions packages/angular_devkit/core/src/analytics/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ export enum NgCliAnalyticsDimensions {
RamInGigabytes = 3,
NodeVersion = 4,
NgAddCollection = 6,
/** @deprecated */
NgBuildBuildEventLog = 7,
NgIvyEnabled = 8,
BuildErrors = 20,
}
Expand Down Expand Up @@ -58,7 +56,6 @@ export const NgCliAnalyticsDimensionsFlagInfo: { [name: string]: [string, string
RamInGigabytes: ['RAM (In GB)', 'number'],
NodeVersion: ['Node Version', 'number'],
NgAddCollection: ['--collection', 'string'],
NgBuildBuildEventLog: ['--buildEventLog', 'boolean'], // deprecated
NgIvyEnabled: ['Ivy Enabled', 'boolean'],
BuildErrors: ['Build Errors (comma separated)', 'string'],
};
Expand Down
3 changes: 2 additions & 1 deletion packages/schematics/angular/application/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,8 @@
"strict": {
"description": "Creates an application with stricter bundle budgets settings.",
"type": "boolean",
"default": false
"default": false,
"x-user-analytics": 7
},
"legacyBrowsers": {
"type": "boolean",
Expand Down
6 changes: 4 additions & 2 deletions packages/schematics/angular/ng-new/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,9 +129,11 @@
"x-user-analytics": 14
},
"strict": {
"description": "Creates a workspace with stricter type checking and stricter bundle budgets settings.",
"description": "Creates a workspace with stricter type checking and stricter bundle budgets settings. This setting helps improve maintainability and catch bugs ahead of time. For more information, see https://angular.io/guide/strict-mode",
"x-prompt": "Do you want to enforce stricter type checking and stricter bundle budgets in the workspace?\n This setting helps improve maintainability and catch bugs ahead of time.\n For more information, see https://angular.io/guide/strict-mode",
"type": "boolean",
"default": false
"default": false,
"x-user-analytics": 7
},
"legacyBrowsers": {
"type": "boolean",
Expand Down
5 changes: 3 additions & 2 deletions packages/schematics/angular/workspace/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,10 @@
"x-user-analytics": 14
},
"strict": {
"description": "Creates a workspace with stricter type checking options.",
"description": "Creates a workspace with stricter type checking options. This setting helps improve maintainability and catch bugs ahead of time. For more information, see https://angular.io/guide/strict-mode",
"type": "boolean",
"default": false
"default": false,
"x-user-analytics": 7
},
"packageManager": {
"description": "The package manager used to install dependencies.",
Expand Down