fix(@angular-devkit/build-angular): add a base href to karma debug context #19119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
approved these changes
Oct 19, 2020
There was a problem hiding this comment.
Thanks, for this @IxquitilisSaid, LGTM.
One small NIT, can you please add the PR description as part of the commit message body and add Closes #19116 as the commit message footer.
See: https://github.com/angular/angular-cli/blob/master/CONTRIBUTING.md#commit for more info.
alan-agius4
added
target: patch
…ntext
This commits adds a base href value in the karma context iframe used to run unit tests where a unit test throws:
No base href set. Please provide a value for the APP_BASE_HREF token or add a base element to the document.
Even if the application is fine.
This is because the index.html from Angular CLI contains a base href value, but not the Karma context iframe.
So when adding a unit test with a testing module that imports a NgModule, for example AppModule,
which itself imports RouterModule, the unit test used to throw an error (regression appeared in router 3.1).
That could be solved by either adding `RouterTestingModule` to the testing module,
or by adding a provider `{ provide: APP_BASE_HREF, useValue: '/' }`, but required to understand the issue.
This solves the issue in a transparent way: developers won't even encounter the problem anymore.
Closes angular#19116
IxquitilisSaid
force-pushed
the
fix-add-base-href-to-karma-debug
branch
from
cc8fa9f
to
24854df
Compare
|
@alan-agius4 I've updated the commit message, hopefully didn't mess it up. |
alan-agius4
approved these changes
Oct 19, 2020
alan-agius4
added
action: merge
|
@googlebot ping! |
Closed
15 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits adds a base href value in the karma context iframe used to run unit tests.
It solves #19116 where a unit test throws:
Even if the application is fine. This is because the index.html from Angular CLI contains a base href value, but not the Karma context iframe. So when adding a unit test with a testing module that imports a NgModule, for example AppModule, which itself imports RouterModule, the unit test used to throw an error (regression appeared in router 3.1).
That could be solved by either adding
RouterTestingModuleto the testing module, or by adding a provider{ provide: APP_BASE_HREF, useValue: '/' }, but required to understand the issue.This solves the issue in a transparent way: developers won't even encounter the problem anymore.