Commits on Oct 19, 2020

1. fix(@angular-devkit/build-angular): add a base href to karma debug co… …

   …ntext
   
   This commits adds a base href value in the karma context iframe used to run unit tests where a unit test throws:
   No base href set. Please provide a value for the APP_BASE_HREF token or add a base element to the document.
   Even if the application is fine.
   This is because the index.html from Angular CLI contains a base href value, but not the Karma context iframe.
   So when adding a unit test with a testing module that imports a NgModule, for example AppModule,
   which itself imports RouterModule, the unit test used to throw an error (regression appeared in router 3.1).
   That could be solved by either adding `RouterTestingModule` to the testing module,
   or by adding a provider `{ provide: APP_BASE_HREF, useValue: '/' }`, but required to understand the issue.
   This solves the issue in a transparent way: developers won't even encounter the problem anymore.
   
   Closes angular#19116

   

   IxquitilisSaid committed Oct 19, 2020
   Configuration menu

   • View commit details
   • Copy full SHA for 24854df
   • Browse repository at this point

   Copy the full SHA

   24854df View commit details

   Browse the repository at this point in the history