Angular CLI 12.2.0 fails "ng add" with "Command aborted." without confirmation prompt #21512

daiplusplus · 2021-08-05T16:58:45Z

🐞 Bug report

Command (mark with an `x`)

Is this a regression?

Did this behavior use to work in the previous version?

Yes

Yes, the previous version in which this bug was not present was: ....

v11 (I haven't used other v12.x versions)

Description and 🔬 Minimal Reproduction

Running ng add always fails with "Command abort.ed" unless I add --skip-confirmation.
Additionally, there is no difference in output with or without --verbose.

For example:

$ cd ~

$ mkdir test

$ cd test

$ npm install -g @angular/cli
# etc

$ ng add @angular-eslint/schematics@12.2.0
- Determining package manager...
i Using package manager: npm
- Loading package information from registry...
√ Package information loaded.
Command aborted.

$ ng add @angular-eslint/schematics --skip-confirmation
- Determining package manager...
i Using package manager: npm
- Searching for compatible package version...
√ Found compatible package version: @angular-eslint/schematics@12.3.1.
- Loading package information from registry...
√ Package information loaded.
- Installing package...
√ Package successfully installed.

    All @angular-eslint dependencies have been successfully installed 🎉

    Please see https://github.com/angular-eslint/angular-eslint for how to add ESLint configuration to your project.


    We detected that you have a single project in your workspace and no existing linter wired up, so we are configuring ESLint for you automatically.

    Please see https://github.com/angular-eslint/angular-eslint for more information.

CREATE .eslintrc.json (984 bytes)
UPDATE package.json (1445 bytes)
UPDATE angular.json (3333 bytes)
- Installing packages (npm)...
√ Packages installed successfully.

🌍 Your Environment


$ node --version
v14.17.4

$ npm --version
7.20.3

$ ng version

     _                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/


Angular CLI: 12.2.0
Node: 14.17.4
Package Manager: npm 7.20.3
OS: win32 x64

Angular: 12.2.0
... animations, cli, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1202.0
@angular-devkit/build-angular   12.2.0
@angular-devkit/core            12.2.0
@angular-devkit/schematics      12.2.0
@schematics/angular             12.2.0
rxjs                            6.6.7
typescript                      4.3.5

Anything else relevant?

Windows 10 x64
Using git-bash as my shell in a mintty window.

I fiddled with add-impl.js to see why it wasn't prompting and I think the problem is add-impl.js has if( !tty_1.isTTY ) { but prompt.js has if (!tty_1.isTTY()) {, so is isTTY a function or a getter-property?

The text was updated successfully, but these errors were encountered:

daiplusplus · 2021-08-05T17:19:42Z

@alan-agius4 The isTTY() change you just made doesn't work for me because when I run it with my additions below, I get typeof process.stdout.isTTY is 'undefined', even though I'm running ng add directly from a terminal window without any redirection (so isTTY should be true, right?)

From Node's docs:

https://nodejs.org/api/tty.html#tty_tty

$ node -p -e "Boolean(process.stdout.isTTY)"
true
$ node -p -e "Boolean(process.stdout.isTTY)" | cat
false

When I run the same commands locally I get the same results:

Screenshot proof:

This the code I added in add-impl.js right before the if (!options.skipConfirmation) { line:

    this.logger.error( options.skipConfirmation ? 'options.skipConfirmation == true' : 'options.skipConfirmation == false' );
    this.logger.error( typeof tty_1.isTTY );
    this.logger.error( 'tty_1.isTTY ==' + ( tty_1.isTTY ? 'isTTY' : 'is NOT TTY' ) );
    this.logger.error( 'tty_1.isTTY() ==' + ( tty_1.isTTY() ? 'isTTY' : 'is NOT TTY' ) );
    this.logger.error( 'process.stdout.isTTY type == ' + ( typeof process.stdout.isTTY ) );
    this.logger.error( 'process.stdout.isTTY == ' + ( process.stdout.isTTY ) );

    if (!options.skipConfirmation) {

Gives me this output:

options.skipConfirmation == false
function
tty_1.isTTY ==isTTY
tty_1.isTTY() ==is NOT TTY
process.stdout.isTTY type == undefined
process.stdout.isTTY == undefined

So why is process.stdout.isTTY undefined when in tty.js but not normally?

daiplusplus · 2021-08-05T17:43:35Z

After some more digging, when I try to get stdout.isTTY from anywhere before add-impl.js runs, such as in init.js or even in ng itself, I get errors.

Here's my code (in C:\Users\me\AppData\Roaming\npm\node_modules\@angular\cli\bin\ng):

process.stdout.write("------------------------\n");
console.trace( "ng: Stack trace\n" );
process.stderr.write("Writing to stderr\n");
process.stdout.write("Writing to stdout\n");
process.stdout.write("typeof stdout.isTTY === '" + typeof process.stdout.isTTY + "'\n");
try { process.stdout.write( process.stdout.isTTY ); }
catch( err ) { process.stdout.write( "Couldn't get isTTY: " + err ); }
process.stdout.write("\n");
process.stdout.write("------------------------\n");

Gives me this output:

$ ng add @angular-eslint/schematics
------------------------
Trace: ng: Stack trrace
    at Object.<anonymous> (C:\Users\me\AppData\Roaming\npm\node_modules\@angular\cli\bin\ng:5:13)
    at Module._compile (internal/modules/cjs/loader.js:1072:14)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1101:10)
    at Module.load (internal/modules/cjs/loader.js:937:32)
    at Function.Module._load (internal/modules/cjs/loader.js:778:12)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:76:12)
    at internal/main/run_main_module.js:17:47
Writing to stderr
Writing to stdout
typeof stdout.isTTY === 'undefined'
Couldn't get isTTY: TypeError [ERR_INVALID_ARG_TYPE]: The "chunk" argument must be of type string or an instance of Buffer or Uint8Array. Received undefined

And yet, running node -p -e "process.stdout.isTTY" directly still works just fine:

$ node -p -e "process.stdout.isTTY"
true

any ideas?

alan-agius4 · 2021-08-05T17:48:34Z

That is interesting, not sure how to debug this from my end since I don’t have a Windows machine.

In the past we did see a number of TTY issues with GitBash and typically they were never actionable form our end. In most cases these were address by Node.JS as far as I can tell.

daiplusplus · 2021-08-05T17:58:19Z

@alan-agius4 I just realised that the error is because stdout.write does not accept a bool parameter - but it's also reporting isTTY is undefined, so I've got my errors crossed - but it's still broken. I'll update this comment in a short while.

daiplusplus · 2021-08-05T18:09:51Z

cmd.exe, when running node.exe myscript.js has process.stdout.isTTY === true.
cmd.exe, when running ng add foobar to indirectly run my hacked ng.js script has process.stdout.isTTY === true.
bash , when running node.exe myscript.js has process.stdout.isTTY === true.
bash, when running ng add foobar to indirectly run my hacked ng.js script has process.stdout.isTTY === undefined.

So that's narrowing it down...

UPDATE: So apparently the culprit is the ng bash script (at C:\Users\me\AppData\Roaming\npm\ng) which runs node via exec, and apparently doing exec node is what causes process.stdout.isTTY to be undefined

daiplusplus · 2021-08-05T18:34:42Z

@alan-agius4

Correct, running node node_modules/@angular/cli/lib/init.js add foobar directly from git-bash has stdout.isTTY === true.

Running node node_modules/@angular/cli/lib/init.js add @angular-eslint/schematics@12.2.0 succeeds and it asks me for a confirmation prompt.

Can't we replace exec node with just node in the ng bash script, perhaps?

Update: I changed my ng bash script from this:

#!/bin/sh
basedir=$(dirname "$(echo "$0" | sed -e 's,\\,/,g')")

case `uname` in
    *CYGWIN*|*MINGW*|*MSYS*) basedir=`cygpath -w "$basedir"`;;
esac

if [ -x "$basedir/node" ]; then
  exec "$basedir/node"  "$basedir/node_modules/@angular/cli/bin/ng" "$@"
else 
  exec node  "$basedir/node_modules/@angular/cli/bin/ng" "$@"
fi

to

#!/bin/sh
basedir=$(dirname "$(echo "$0" | sed -e 's,\\,/,g')")

case `uname` in
    *CYGWIN*|*MINGW*|*MSYS*) basedir=`cygpath -w "$basedir"`;;
esac

if [ -x "$basedir/node" ]; then
  node  "$basedir/node_modules/@angular/cli/bin/ng" "$@"
else 
  node  "$basedir/node_modules/@angular/cli/bin/ng" "$@"
fi

And yet process.stdout.isTTY === undefined still, curious...

Perhaps as an immediate workaround, add a warning output to init.js if typeof isTTY !== 'boolean' ?

daiplusplus · 2021-08-05T19:06:25Z

I've raised a bug with NodeJS here: nodejs/node#39673

UPDATE: So while the root cause is that isTTY is undefined in NodeJS when bash-on-Windows indirectly, which is another example of "the winpty problem" described here: https://stackoverflow.com/questions/45890339/stdout-is-not-a-tty-using-bash-for-node-tape-tap-spec

As a quality-of-life improvement, I suggest the ng shell-script print a warning if winpty isn't available, and if so, run the child node process via winpty, thoughts?

alan-agius4 · 2021-08-05T19:53:27Z

@Jehoel, the mentioned shell script is actually generated by NPM and not Angular.
Hence we have no controller of its contents.

…sing `--skip-confirmation` during `ng add` Closes #21512

…sing `--skip-confirmation` during `ng add` Closes #21512 (cherry picked from commit c0f1b5e)

diegoatnqn · 2021-08-12T04:22:00Z

All ng add commands are not working for me either.
My version:

Angular CLI: 12.0.5
Node: 16.5.0
Package Manager: npm 7.20.0
OS: win32 x64
Angular: 12.0.5
... animations, cli, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router

Package Version

@angular-devkit/architect 0.1200.5
@angular-devkit/build-angular 12.0.5
@angular-devkit/core 12.0.5
@angular-devkit/schematics 12.0.5
@angular/cdk 12.1.3
@angular/material 12.1.3
@schematics/angular 12.0.5
rxjs 6.6.7
typescript 4.2.4

angular-automatic-lock-bot · 2021-09-12T08:02:41Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

alan-agius4 added area: angular/cli freq1: low Only reported by a handful of users who observe it rarely severity3: broken labels Aug 5, 2021

ngbot bot modified the milestone: needsTriage Aug 5, 2021

alan-agius4 mentioned this issue Aug 5, 2021

fix(@angular/cli): show error when using non-TTY terminal without passing --skip-confirmation during ng add #21513

Merged

alan-agius4 added severity1: confusing type: bug/fix and removed severity3: broken labels Aug 5, 2021

ngbot bot modified the milestones: needsTriage, Backlog Aug 5, 2021

daiplusplus mentioned this issue Aug 5, 2021

ng add @angular-eslint/schematics fails without explanation (even with --verbose) angular-eslint/angular-eslint#626

Closed

2 tasks

daiplusplus mentioned this issue Aug 5, 2021

process.stdout.isTTY is undefined when git-bash (on Windows) invokes node via a shell script nodejs/node#39673

Closed

alan-agius4 closed this as completed in #21513 Aug 6, 2021

alan-agius4 added a commit that referenced this issue Aug 6, 2021

fix(@angular/cli): show error when using non-TTY terminal without pas…

c0f1b5e

…sing `--skip-confirmation` during `ng add` Closes #21512

alan-agius4 added a commit that referenced this issue Aug 6, 2021

fix(@angular/cli): show error when using non-TTY terminal without pas…

8dc3c89

…sing `--skip-confirmation` during `ng add` Closes #21512 (cherry picked from commit c0f1b5e)

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Angular CLI 12.2.0 fails "ng add" with "Command aborted." without confirmation prompt #21512

Angular CLI 12.2.0 fails "ng add" with "Command aborted." without confirmation prompt #21512

daiplusplus commented Aug 5, 2021 •

edited

daiplusplus commented Aug 5, 2021 •

edited

daiplusplus commented Aug 5, 2021 •

edited

alan-agius4 commented Aug 5, 2021

daiplusplus commented Aug 5, 2021

daiplusplus commented Aug 5, 2021 •

edited

daiplusplus commented Aug 5, 2021 •

edited

daiplusplus commented Aug 5, 2021 •

edited

alan-agius4 commented Aug 5, 2021 •

edited

diegoatnqn commented Aug 12, 2021 •

edited

Package Version

angular-automatic-lock-bot bot commented Sep 12, 2021

Angular CLI 12.2.0 fails "ng add" with "Command aborted." without confirmation prompt #21512

Angular CLI 12.2.0 fails "ng add" with "Command aborted." without confirmation prompt #21512

Comments

daiplusplus commented Aug 5, 2021 • edited

🐞 Bug report

Command (mark with an x)

Is this a regression?

Description and 🔬 Minimal Reproduction

🌍 Your Environment

daiplusplus commented Aug 5, 2021 • edited

daiplusplus commented Aug 5, 2021 • edited

alan-agius4 commented Aug 5, 2021

daiplusplus commented Aug 5, 2021

daiplusplus commented Aug 5, 2021 • edited

daiplusplus commented Aug 5, 2021 • edited

daiplusplus commented Aug 5, 2021 • edited

alan-agius4 commented Aug 5, 2021 • edited

diegoatnqn commented Aug 12, 2021 • edited

Package Version

angular-automatic-lock-bot bot commented Sep 12, 2021

daiplusplus commented Aug 5, 2021 •

edited

Command (mark with an `x`)

daiplusplus commented Aug 5, 2021 •

edited

daiplusplus commented Aug 5, 2021 •

edited

daiplusplus commented Aug 5, 2021 •

edited

daiplusplus commented Aug 5, 2021 •

edited

daiplusplus commented Aug 5, 2021 •

edited

alan-agius4 commented Aug 5, 2021 •

edited

diegoatnqn commented Aug 12, 2021 •

edited