Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for environment-based build pipeline #230

Closed
jeffbcross opened this issue Feb 19, 2016 · 3 comments
Closed

feat: add support for environment-based build pipeline #230

jeffbcross opened this issue Feb 19, 2016 · 3 comments

Comments

@jeffbcross
Copy link
Contributor

In #215, where AppCache/ServiceWorker support was implemented, the feature was limited because there was no way to differentiate between a build for dev and a build for prod inside lib/broccoli/angular2-app.js.

The service worker or app cache should not be installed for dev builds by default, since it would interfere with rapid change app > reload > repeat lifecycle.

I'm just opening this issue for discussion/tracking of allowing different behavior for different environments; I don't have a proposed design. Given that dev and prod builds should generally not exhibit different behavior, this design should have good constraints to discourage abuse.

@cironunes
Copy link
Member

I'm looking into this, but didn't make much progress yet.

@hansl
Copy link
Contributor

hansl commented Mar 18, 2016

I'll close this in favor of #41. Cirocunes is already working on this.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants