feat: Generate an AppCache/ServiceWorker manifest during the build step. #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,6 +6,18 @@ | |||
| <base href="/"> | |||
| {{content-for 'head'}} | |||
| <link rel="icon" type="image/x-icon" href="favicon.ico"> | |||
|
|
|||
| <!-- Service worker support is disabled by default. | |||
| Install the worker script and uncomment to enable. | |||
There was a problem hiding this comment.
Could you add some more detail about how to install the worker script?
alxhub
force-pushed
the
sw-integration
branch
3 times, most recently
from
ee72835
to
3590ff0
Compare
|
LGTM. Good work. Not sure how long we'll keep this in the main repo but having the experience definitely helped shaping the build system. |
…ep, from all of the resources in the output directory.
alxhub
force-pushed
the
sw-integration
branch
from
3590ff0
to
0228140
Compare
clydin
pushed a commit
that referenced
this pull request
Jun 5, 2018
Some code already have been compiled to use tslib. The decorators should be stripped for those as well. Fixes #215
hansl
added a commit
that referenced
this pull request
Jun 6, 2018
Some code already have been compiled to use tslib. The decorators should be stripped for those as well. Fixes #215
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a build step to generate a
manifest.appcachefile from the full set of resources built for the application.It includes a commented-out snippet in
index.htmlto install a worker entitled/worker.js. This is because the worker must be disabled during development for the edit-save-refresh cycle to pick up changes, but should be enabled in production, and there is no good way to switch this at the moment.The worker script itself is also not included - eventually project generation should conditionally install
angular2-service-workerand use the worker script included in that. I will explore this option in a future PR.