New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generators: allow dash -
in selector before a number
#25164
Labels
area: schematics/angular
freq1: low
Only reported by a handful of users who observe it rarely
severity3: broken
type: bug/fix
Comments
alan-agius4
added
type: bug/fix
freq1: low
Only reported by a handful of users who observe it rarely
severity3: broken
area: schematics/angular
labels
May 8, 2023
Hi @alan-agius4. I would like to take this up |
@sumitparakh go for it. |
sumitparakh
pushed a commit
to sumitparakh/angular-cli
that referenced
this issue
May 20, 2023
13 tasks
sumitparakh
added a commit
to sumitparakh/angular-cli
that referenced
this issue
May 20, 2023
sumitparakh
pushed a commit
to sumitparakh/angular-cli
that referenced
this issue
May 22, 2023
Closes angular#25164 fix(@angular/cli): fix regex fix(@angular/cli): updated test case fix(@angular/cli): fix "too big tests" error in ci added a new file to test dash with number case
sumitparakh
pushed a commit
to sumitparakh/angular-cli
that referenced
this issue
May 22, 2023
Closes angular#25164 fix(@angular/cli): fix regex fix(@angular/cli): updated test case fix(@angular/cli): fix "too big tests" error in ci added a new file to test dash with number case
sumitparakh
pushed a commit
to sumitparakh/angular-cli
that referenced
this issue
May 24, 2023
Closes angular#25164 fix(@angular/cli): fix regex fix(@angular/cli): updated test case fix(@angular/cli): fix "too big tests" error in ci added a new file to test dash with number case
sumitparakh
pushed a commit
to sumitparakh/angular-cli
that referenced
this issue
May 24, 2023
This commit updates the validator regexp to allow a dash before a number. Closes angular#25164
sumitparakh
pushed a commit
to sumitparakh/angular-cli
that referenced
this issue
May 24, 2023
This commit updates the validator regexp to allow a dash before a number. Closes angular#25164
sumitparakh
pushed a commit
to sumitparakh/angular-cli
that referenced
this issue
May 30, 2023
This commit updates the validator regexp to allow a dash before a number. Closes angular#25164
sumitparakh
pushed a commit
to sumitparakh/angular-cli
that referenced
this issue
Jun 3, 2023
This commit updates the validator regexp to allow a dash before a number. Closes angular#25164
sumitparakh
added a commit
to sumitparakh/angular-cli
that referenced
this issue
Jun 3, 2023
sumitparakh
pushed a commit
to sumitparakh/angular-cli
that referenced
this issue
Jun 3, 2023
This commit updates the validator regexp to allow a dash before a number. Closes angular#25164
sumitparakh
pushed a commit
to sumitparakh/angular-cli
that referenced
this issue
Jun 3, 2023
This commit updates the validator regexp to allow a dash before a number. Closes angular#25164
alan-agius4
pushed a commit
that referenced
this issue
Oct 26, 2023
This commit updates the validator regexp to allow a dash before a number. Closes #25164
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area: schematics/angular
freq1: low
Only reported by a handful of users who observe it rarely
severity3: broken
type: bug/fix
Command
generate
Description
We use jira. Tickets always follow the schema
<PROJECT>-<TICKETNUMBER>
so e.g.Task-123
. If we do an a/b test, we like to postfix the files that mirror the control group with the ticket, so e.gfeature-task-123.component.ts
. But the cli right now doesn't allow this.See
ng g c TodoItemTask123
neither the files nor the selector have the-
. Sotask-123
is actuallytask123
:So what I'd like to do would be one of these:
but both commands get rejected with
Selector "app-todo-item-task-123" is invalid
:Describe the solution you'd like
I'd like if
ng g c TodoItemTask-123
was allowed and generates files like:Describe alternatives you've considered
Renaming all the files and updating the NgModule by hand afterwards.
The text was updated successfully, but these errors were encountered: