-
Notifications
You must be signed in to change notification settings - Fork 12k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import from
from rxjs errors out the SSRing of the application
#26235
Labels
area: devkit/build-angular
devkit/build-angular:dev-server
freq1: low
Only reported by a handful of users who observe it rarely
severity3: broken
type: bug/fix
Comments
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this issue
Nov 6, 2023
…or SSR It appears that Vite currently, has a number of limitation/bugs when using `optimizeDeps` for SSR bundles. Currently this causes a number of issues: - Deps are re-optimized everytime the server is started. - Added deps after a rebuild are not optimized. - Breaks RxJs (Unless it is added as external). See: angular#26235 We should follow up with Vite and try to get this solved as this would be a nice feature to use. Closes angular#26235 and angular#26234
alan-agius4
added a commit
to alan-agius4/angular-cli
that referenced
this issue
Nov 6, 2023
…or SSR It appears that Vite currently, has a number of limitation/bugs when using `optimizeDeps` for SSR bundles. Currently this causes a number of issues: - Deps are re-optimized everytime the server is started. - Added deps after a rebuild are not optimized. - Breaks RxJs (Unless it is added as external). See: angular#26235 We should follow up with Vite and try to get this solved as this would be a nice feature to use. Closes angular#26235 and angular#26234
alan-agius4
added a commit
that referenced
this issue
Nov 6, 2023
…or SSR It appears that Vite currently, has a number of limitation/bugs when using `optimizeDeps` for SSR bundles. Currently this causes a number of issues: - Deps are re-optimized everytime the server is started. - Added deps after a rebuild are not optimized. - Breaks RxJs (Unless it is added as external). See: #26235 We should follow up with Vite and try to get this solved as this would be a nice feature to use. Closes #26235 and #26234
alan-agius4
added a commit
that referenced
this issue
Nov 6, 2023
…or SSR It appears that Vite currently, has a number of limitation/bugs when using `optimizeDeps` for SSR bundles. Currently this causes a number of issues: - Deps are re-optimized everytime the server is started. - Added deps after a rebuild are not optimized. - Breaks RxJs (Unless it is added as external). See: #26235 We should follow up with Vite and try to get this solved as this would be a nice feature to use. Closes #26235 and #26234 (cherry picked from commit 7cb5d35)
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area: devkit/build-angular
devkit/build-angular:dev-server
freq1: low
Only reported by a handful of users who observe it rarely
severity3: broken
type: bug/fix
Command
serve
Is this a regression?
The previous version in which this bug was not present was
No response
Description
Importing and using
from
from rxjs throws error once page is requestedMinimal Reproduction
https://github.com/yharaskrik/angular-17-ssr-application-builder/tree/jaybell/from-rxjs-issue
yarn ng serve
open localhost:4200
Exception or Error
Your Environment
Anything else relevant?
No response
The text was updated successfully, but these errors were encountered: