Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Esbuilder cannot localize 3rd party components #26350

Open
1 task
destus90 opened this issue Nov 14, 2023 · 0 comments
Open
1 task

Esbuilder cannot localize 3rd party components #26350

destus90 opened this issue Nov 14, 2023 · 0 comments

Comments

@destus90
Copy link
Contributor

Command

serve

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

I am start using the new angular builder and stuck with localizing an app. The texts are stayed in a source locale and the corresponding LOCALE_ID is not provided.

Minimal Reproduction

  1. git clone https://github.com/destus90/angular-esbuilder-kendo-localization
  2. npm install
  3. npm run start:fr
  4. Observe browser's console (the provided LOCALE_ID is 'en-US') and the texts are not translated into French

Exception or Error

No response

Your Environment

_                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/
    

Angular CLI: 17.0.0
Node: 20.7.0
Package Manager: npm 10.1.0
OS: win32 x64

Angular: 17.0.0
... animations, cli, common, compiler, compiler-cli, core, forms
... localize, platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1700.0
@angular-devkit/build-angular   17.0.0
@angular-devkit/core            17.0.0
@angular-devkit/schematics      17.0.0
@schematics/angular             17.0.0
rxjs                            7.8.1
typescript                      4.9.5
zone.js                         0.14.2

Anything else relevant?

No response

@alan-agius4 alan-agius4 added devkit/build-angular:dev-server freq1: low Only reported by a handful of users who observe it rarely severity3: broken and removed devkit/build-angular:i18n labels Nov 24, 2023
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Nov 24, 2023
…uild based builders

In some cases the `$localize.locale` was being set prior to `$localize` being set through `@angular/localize`. This caused `$localize.locale` to be reset to `en-US`.

This change moves the order in which `$localize.locale` is set.

Partially addresses: angular#26350
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Nov 24, 2023
…uild based builders

In some cases the `$localize.locale` was being set prior to `$localize` being set through `@angular/localize`. This caused `$localize.locale` to be reset to `en-US`.

This change moves the order in which `$localize.locale` is set.

Partially addresses: angular#26350
alan-agius4 added a commit that referenced this issue Nov 27, 2023
…uild based builders

In some cases the `$localize.locale` was being set prior to `$localize` being set through `@angular/localize`. This caused `$localize.locale` to be reset to `en-US`.

This change moves the order in which `$localize.locale` is set.

Partially addresses: #26350
alan-agius4 added a commit that referenced this issue Nov 27, 2023
…uild based builders

In some cases the `$localize.locale` was being set prior to `$localize` being set through `@angular/localize`. This caused `$localize.locale` to be reset to `en-US`.

This change moves the order in which `$localize.locale` is set.

Partially addresses: #26350

(cherry picked from commit 876ca1e)
@mgechev mgechev added freq2: medium freq1: low Only reported by a handful of users who observe it rarely and removed freq1: low Only reported by a handful of users who observe it rarely freq2: medium labels Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants