feature(universal): add support for Angular Universal #2749

devCrossNet · 2016-10-17T14:23:42Z

add the possibility to scaffold a universal project with --universal.

This is the next attempt to bring in the --universal feature flag.
Related PR: #2318

It is rebased onto the angular-cli/master branch and will update the angular-cli/universal branch.

…oblem(angular#1889) Fix angular#1889 Close angular#1890

This removes the following warning about webpack dependency. npm WARN string-replace-loader@1.0.3 requires a peer of webpack@1.x.x || 2.x.x but none was installed. Close angular#2265

Close angular#2362

Fix angular#2288 Close angular#2492

Fix angular#2099 Close angular#2528

fix angular#2396

Close angular#2527

Fix angular#2135 Close angular#2178

…anisabboud

…anisabboud (angular#2604)

Allows for faster builds, partially addresses angular#1980

…lar#2580) Fixes angular#2300

…ar#2486) With angular#1814 the `defaults.poll` property was added to angular-cli.json. This configuration setting currently applies to `ng serve` but not `ng test`. This fix adds the poll value to the karma defaults so that if you set `defaults: { poll: 1000 }` it will apply to both `ng serve` and `ng test`.

…ngular#2565) Earlier invalid angular-cli.json yielded only "Error". Now it prints something like: Parsing angular-cli.json failed. Please make sure your angular-cli.json is valid JSON. Error: SyntaxError: Unexpected token s in JSON at position 2 Almost the same message is now also used for the other configuration files (schema and other).

Fix angular#2284 Close angular#2286

Close angular#2484

Closes angular#1081 Close angular#2489

Fix angular#2533 Close angular#2519

Close angular#2547

Close angular#2553

Close angular#2593

Fix angular@06976f4#commitcomment-19241601 Close angular#2595

Added FAQ label note, assets note, removed dead links/sections. Fix angular#2411 Close angular#2596

Fix angular#2206 Close angular#2597

Follow up from angular#2158 Fix angular#2511 Close angular#2611

Fix angular#1900 Close angular#2614

devCrossNet · 2016-10-18T18:38:32Z

Can someone give me a hint why this is happening on appvayor:

test-project@0.0.0 pree2e C:\Users\appveyor\AppData\Local\Temp\1\angular-cli-e2e-116918-1312-ufniqq\test-project
webdriver-manager update

C:\Users\appveyor\AppData\Local\Temp\1\angular-cli-e2e-116918-1312-ufniqq\test-project\node_modules\protractor\node_modules\webdriver-manager\built\lib\cmds\update.js:63
var gecko = options[Opt.GECKO].getBoolean();
^

I tested this code on Windows 10 64-bit (Node 4/6), Linux Mint 17 (Node 4/6), OSX (Node 4/6) and it worked.

Did I miss some dependency updates? I don't see it.

Brocco · 2016-10-18T19:00:54Z

You can ignore appveyor for now... there's a bug unrelated to our code... I believe when installing a web driver.

filipesilva · 2016-10-18T19:01:40Z

@devCrossNet context for that error: angular/webdriver-manager#107. It's not something we can fix on our side, I think.

add the possibility to scaffold a universal project with --universal

devCrossNet · 2016-10-18T23:38:36Z

So, the PR is ready then?

chrillewoodz · 2016-10-19T04:59:22Z

So the --univseral flag is available now in the CLI if I update?

devCrossNet · 2016-10-19T09:12:33Z

@chrillewoodz it has to be published to npm first. @Brocco do you know when it'll be available?

webmutation · 2016-10-19T12:48:26Z

Where is the seed (git url) of the universal project that gets generated?

devCrossNet · 2016-10-19T13:02:21Z

@webmutation here is the blueprint: https://github.com/angular/angular-cli/tree/universal/packages/angular-cli/blueprints/universal. It is based on https://github.com/angular/universal-starter

kylecordes · 2016-10-19T13:05:50Z

I realize that this optional support for universal is already merged; but I wonder if the project might consider an alternative model?

Maybe "all CLI projects are universal" instead of "there is a switch you can flip, but most people don't flip it, so will likely be issues that come up which are different for universal projects".

webmutation · 2016-10-19T13:13:05Z

@devCrossNet Thanks! Ah, its part of the CLI, i was expecting the mechanism would be more expandable, where it would be possible to point to custom blueprints thru a url, something similar to

ngt new PROJECT-NAME --url:https://github.com/mgechev/angular2-seed (Whatever seed/blueprint)

devCrossNet · 2016-10-19T13:13:23Z

@kylecordes there is a lot going on at the moment. this is the first try to figure out how people will use it and how it can be finally integrated to the CLI. We also have to figure out how to play well with the --mobile flag. Or if we should combine --mobile and --universal but with different build targets like prerenderand rerender. But for now, the goal is to get the main CLI to have the 1.0.0 stable release.

devCrossNet · 2016-10-19T13:23:04Z

@webmutation this kind of mechanism would be part of the core functionality of the CLI. I don't know if the CLI team is planning something like this. My goal is, to integrate a possibility to use universal within the CLI, based on the best practices of the Universal team.

goriunov · 2016-10-22T05:28:55Z

Hello , thank you very much for your work , i found that angular universal
"angular2-platform-node": "~2.0.11",
"angular2-universal": "~2.0.11",
"angular2-universal-polyfills": "~2.0.11",
"angular2-express-engine": "~2.0.11",
does not work well with
@angular/compiler": "^2.1.0",

it shows error
var SelectorMatcher = compiler_1.compiler_private.SelectorMatcher, CssSelector = compiler_1.compiler_private.CssSelector;
TypeError: Cannot read property 'SelectorMatcher' of undefined

probably need to renew dependency

devCrossNet · 2016-10-22T11:00:28Z

@goriunov I disabled the aot support for now. But I want to update the dependencies anyways :-) maybe I can get it to work.

elekzalan · 2016-10-24T07:09:02Z

@devCrossNet Hello. You have any idea, when the --aot flag is going to work? angular2-universal supports aot compilation since version 2.1.0-rc.1. Thank you for your work on this awesome project. 😃

MarkPieszak · 2016-10-24T13:52:38Z

@goriunov Please use 2.1.0 for Angular Core packages. 2.1.1 changed CssSelector & SelectorMatcher and I'm working on getting the fix in to Universal at the moment. You can follow angular/universal#607 for when they'll be fixed so that we can use 2.1.1 with Universal.

@elekzalan Once we can get a few fixes in there we'll release Universal as 2.1.1, which hopefully will include AoT, the internal compiler fixes (mentioned in my previous comment), etc.

jaumard · 2016-10-30T20:57:57Z

Is the --universal on the last npm version ? Because I didn't find anything on on docs about the flag and generate a new app with it doesn't embed universal :(

kuldeepkeshwar · 2016-11-10T08:01:33Z

@devCrossNet does it support AOT with universal 2.1.0-rc.1 ?

devCrossNet · 2016-11-10T08:31:36Z

@jaumard the universal-cli support is now a separate package on npm universal-cli

@kuldeepkeshwar no, it is still on universal version 2.0.11, waiting for version 2.1.1.

chrillewoodz · 2016-11-10T10:46:58Z

@devCrossNet Why is it a separate package?

devCrossNet · 2016-11-10T11:17:43Z

@chrillewoodz please read this comment: #1050 (comment)

chrillewoodz · 2016-11-10T11:29:41Z

@devCrossNet Ok makes sense. And you have to uninstall the angular-cli the same way as before, before installing the universal-cli?

devCrossNet · 2016-11-10T14:32:38Z

@chrillewoodz yes

chrillewoodz · 2016-11-12T14:39:34Z

Has the universal-cli been removed again? Can't seem to find it anymore.

devCrossNet · 2016-11-12T16:16:52Z

https://www.npmjs.com/package/universal-cli

https://github.com/devCrossNet/angular-cli

angular-automatic-lock-bot · 2019-09-11T17:40:47Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

hansl and others added 30 commits October 4, 2016 15:34

feat(aot): do not populate the whole filesystem if nothing changed (a…

b5771df

…ngular#2490)

fix(cli): fix completion and make-this-awesome command invalid pr…

4b36ecf

…oblem(angular#1889) Fix angular#1889 Close angular#1890

Update string-replace-loader to 1.0.5

d8fb444

This removes the following warning about webpack dependency. npm WARN string-replace-loader@1.0.3 requires a peer of webpack@1.x.x || 2.x.x but none was installed. Close angular#2265

fix(webpack): Added ContextReplacementPlugin to remove ng test warning

c2f4b37

Close angular#2362

bugfix(generate): removes bad imports when generating a class

9d4efb5

Fix angular#2288 Close angular#2492

chore(deps): explicitely add @types/node

1524bc1

Fix angular#2099 Close angular#2528

chore(docs): elaborate node/npm prereqs (angular#2534)

b5f65d3

fix(build): remove html-loader (angular#2537)

afb36e8

fix angular#2396

feat(aot): adding README and type checking.

8a5b265

Close angular#2527

fix: check for old version of the CLI on empty project

2b6bfe7

Fix angular#2135 Close angular#2178

v1.0.0-beta.17

1b46c11

feat(build): add support for assets array (angular#2570)

de3c275

Missed a double semi-colon at the end of gh-pages:deploy, caught by @…

a66c8cc

…anisabboud (angular#2604)

chore(build): use cheap-module-source-map for dev (angular#2619)

dbdf46c

Allows for faster builds, partially addresses angular#1980

bug(help): show correct listing of blueprints for generate help (angu…

fbc585b

…lar#2580) Fixes angular#2300

fix(angular#1875): Support npm linked libraries (angular#2291)

8bf69d9

feature(completion): ng completion made more robust

8bec76d

Fix angular#2284 Close angular#2286

chore(changelog): links correction

f8defb5

Close angular#2484

feat(serve): implement open browser option

8bddabe

Closes angular#1081 Close angular#2489

fix(build): fix sourcemap in prod

d292eac

Fix angular#2533 Close angular#2519

chore(webpack) add repo info for webpack plugin

972a35b

Close angular#2547

fix(doc): update invalid link

e17d4a8

Close angular#2553

feat(build): added postcss-discard-comments

883fe46

Close angular#2593

fix(new): add prefix to spec name

1307dc8

Fix angular@06976f4#commitcomment-19241601 Close angular#2595

chore(readme): minor cleanup

9554ade

Added FAQ label note, assets note, removed dead links/sections. Fix angular#2411 Close angular#2596

fix(new): fix relativeRootPath for typeRoots

eb2f939

Fix angular#2206 Close angular#2597

fix(build): use outputPath from config

ec0cdb5

Follow up from angular#2158 Fix angular#2511 Close angular#2611

fix(set): output value for additional props

f7bf0aa

Fix angular#1900 Close angular#2614

feature(universal): add support for Angular Universal

d422208

add the possibility to scaffold a universal project with --universal

devCrossNet force-pushed the universal-webpack branch from 75f988a to d422208 Compare October 18, 2016 20:26

Brocco merged commit 1026670 into angular:universal Oct 19, 2016

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feature(universal): add support for Angular Universal #2749

feature(universal): add support for Angular Universal #2749

devCrossNet commented Oct 17, 2016

devCrossNet commented Oct 18, 2016

Brocco commented Oct 18, 2016

filipesilva commented Oct 18, 2016

devCrossNet commented Oct 18, 2016

chrillewoodz commented Oct 19, 2016

devCrossNet commented Oct 19, 2016

webmutation commented Oct 19, 2016 •

edited

devCrossNet commented Oct 19, 2016

kylecordes commented Oct 19, 2016

webmutation commented Oct 19, 2016 •

edited

devCrossNet commented Oct 19, 2016

devCrossNet commented Oct 19, 2016

goriunov commented Oct 22, 2016 •

edited

devCrossNet commented Oct 22, 2016

elekzalan commented Oct 24, 2016 •

edited

MarkPieszak commented Oct 24, 2016 •

edited

jaumard commented Oct 30, 2016

kuldeepkeshwar commented Nov 10, 2016

devCrossNet commented Nov 10, 2016

chrillewoodz commented Nov 10, 2016

devCrossNet commented Nov 10, 2016

chrillewoodz commented Nov 10, 2016

devCrossNet commented Nov 10, 2016

chrillewoodz commented Nov 12, 2016

devCrossNet commented Nov 12, 2016

angular-automatic-lock-bot bot commented Sep 11, 2019

feature(universal): add support for Angular Universal #2749

feature(universal): add support for Angular Universal #2749

Conversation

devCrossNet commented Oct 17, 2016

devCrossNet commented Oct 18, 2016

Brocco commented Oct 18, 2016

filipesilva commented Oct 18, 2016

devCrossNet commented Oct 18, 2016

chrillewoodz commented Oct 19, 2016

devCrossNet commented Oct 19, 2016

webmutation commented Oct 19, 2016 • edited

devCrossNet commented Oct 19, 2016

kylecordes commented Oct 19, 2016

webmutation commented Oct 19, 2016 • edited

devCrossNet commented Oct 19, 2016

devCrossNet commented Oct 19, 2016

goriunov commented Oct 22, 2016 • edited

devCrossNet commented Oct 22, 2016

elekzalan commented Oct 24, 2016 • edited

MarkPieszak commented Oct 24, 2016 • edited

jaumard commented Oct 30, 2016

kuldeepkeshwar commented Nov 10, 2016

devCrossNet commented Nov 10, 2016

chrillewoodz commented Nov 10, 2016

devCrossNet commented Nov 10, 2016

chrillewoodz commented Nov 10, 2016

devCrossNet commented Nov 10, 2016

chrillewoodz commented Nov 12, 2016

devCrossNet commented Nov 12, 2016

angular-automatic-lock-bot bot commented Sep 11, 2019

webmutation commented Oct 19, 2016 •

edited

webmutation commented Oct 19, 2016 •

edited

goriunov commented Oct 22, 2016 •

edited

elekzalan commented Oct 24, 2016 •

edited

MarkPieszak commented Oct 24, 2016 •

edited